Add test for opening private window from about:privatebrowsing

NEW
Unassigned

Status

()

defect
4 years ago
4 years ago

People

(Reporter: smacleod, Unassigned)

Tracking

Trunk
Points:
1
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

No description provided.
Flags: qe-verify-
Flags: firefox-backlog+
/r/5211 - Bug 1142240 - Add test for opening private window from about:privatebrowsing; r=mossop

Pull down this commit:

hg pull review -r bc665b426c463867d4773735f19378d5ae902743
Attachment #8576242 - Flags: review?(dtownsend)
Comment on attachment 8576242 [details]
MozReview Request: bz://1142240/smacleod

https://reviewboard.mozilla.org/r/5209/#review4253

Ship It!
Attachment #8576242 - Flags: review?(dtownsend) → review+
Backed out (next to bug 1079245) in https://hg.mozilla.org/integration/fx-team/rev/988afda9eac4 for being the likely cause of some new intermittent privatebrowsing test failures:
https://treeherder.mozilla.org/logviewer.html#?job_id=2327926&repo=fx-team
Flags: needinfo?(smacleod)
Iteration: 39.2 - 23 Mar → 39.3 - 30 Mar
Iteration: 39.3 - 30 Mar → 40.1 - 13 Apr
The intermittents were almost certainly the result of Bug 1079245 and not this commit which is just an additional test. I've relanded this test only:

https://hg.mozilla.org/integration/fx-team/rev/a1a88af9e251
Flags: needinfo?(smacleod)
(In reply to Wes Kocher (:KWierso) from comment #6)
> Backed out for leaking in bc1:

I'm not sure what changed in between my rebase to make this leak. I'm not going to be working on fixing this but it shouldn't be too hard for someone else to pickup.
Assignee: smacleod → nobody
Status: ASSIGNED → NEW
Flags: needinfo?(smacleod)
Iteration: 40.1 - 13 Apr → ---
Attachment #8576242 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.