1142240 - Add test for opening private window from about:privatebrowsing

Status: NEW

(Firefox :: Private Browsing, defect)

Comment 1

[Steven MacLeod [:smacleod]]

Attachment: MozReview Request: bz://1142240/smacleod

/r/5211 - Bug 1142240 - Add test for opening private window from about:privatebrowsing; r=mossop

Pull down this commit:

hg pull review -r bc665b426c463867d4773735f19378d5ae902743

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8576242 [details]
MozReview Request: bz://1142240/smacleod

https://reviewboard.mozilla.org/r/5209/#review4253

Ship It!

Comment 3

[Steven MacLeod [:smacleod]]

https://hg.mozilla.org/integration/fx-team/rev/b467fad71782

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out (next to bug 1079245) in https://hg.mozilla.org/integration/fx-team/rev/988afda9eac4 for being the likely cause of some new intermittent privatebrowsing test failures:
https://treeherder.mozilla.org/logviewer.html#?job_id=2327926&repo=fx-team

Comment 5

[Steven MacLeod [:smacleod]]

The intermittents were almost certainly the result of Bug 1079245 and not this commit which is just an additional test. I've relanded this test only:

https://hg.mozilla.org/integration/fx-team/rev/a1a88af9e251

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for leaking in bc1: https://hg.mozilla.org/integration/fx-team/rev/6177eed6d23d

https://treeherder.mozilla.org/logviewer.html#?job_id=2546238&repo=fx-team

Comment 7

[Steven MacLeod [:smacleod]]

(In reply to Wes Kocher (:KWierso) from comment #6)
> Backed out for leaking in bc1:

I'm not sure what changed in between my rebase to make this leak. I'm not going to be working on fixing this but it shouldn't be too hard for someone else to pickup.