Closed Bug 1142369 Opened 8 years ago Closed 8 years ago

Unexpected line break inside <li>

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla39
Tracking Flags:
Tracking Status
firefox36 --- affected
firefox37 --- affected
firefox38 --- fixed
firefox39 --- fixed
firefox-esr31 --- unaffected

People

(Reporter: alice0775, Assigned: xidorn)

References

Details

(Keywords: regression, Whiteboard: [parity-Chrome][parity-IE])

Attachments

(3 files, 1 obsolete file)

index.html
191 bytes, text/html
Details
screenshot
115.33 KB, image/png
Details
patch
3.01 KB, patch
roc
: review+
lizzard
: approval-mozilla-aurora+
Details | Diff | Splinter Review
Attached file index.html — 
Steps To reproduce:
1: Open attached

Actual Results:
Unexpected line break

Expected results:
No line break

Pushlog:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=6fcbe7b1dec2&tochange=1f7ccdfe2c6e

Regressed by: Bug 1013160
Flags: needinfo?(quanxunzhen)
Attached image screenshot — 

    
  
Whiteboard: [parity-Chrome][parity-IE]

    
  
Blocks: 1142340

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch (obsolete)
        — 
          — Splinter Review
      

    


  
Assignee: nobody → quanxunzhen
Flags: needinfo?(quanxunzhen)

        Attachment #8576446 -
        Flags: review?(roc)

    
    

    
  
Thanks for reporting this bug. I think I noticed this problem before, but didn't know the impact of it, neither how can I test it. But when I know the impact, I've forgotten this problem :)

    
  
OS: Windows 7 → All
Hardware: x86_64 → All
Version: 32 Branch → Trunk

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  
forgot to add reftest

        Attachment #8576446 -
        Attachment is obsolete: true

        Attachment #8576446 -
        Flags: review?(roc)

        Attachment #8576449 -
        Flags: review?(roc)

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/b7027d5ce2fe
Status: NEW → RESOLVED
Closed: 8 years ago

          status-firefox39:
          affected → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla39

    
    

    
  
Comment on attachment 8576449 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: bug 1013160
[User impact if declined]: see undesired line break inside <li> if they put them in float block or table.
[Describe test coverage new/current, TreeHerder]: related reftest is included in this patch
[Risks and why]: not aware of any risk
[String/UUID change made/needed]: n/a

        Attachment #8576449 -
        Flags: approval-mozilla-aurora?

    
    

    
  
Comment on attachment 8576449 [details] [diff] [review]
patch

Approving for uplift to aurora since this has test coverage and sounds low risk.

        Attachment #8576449 -
        Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

          You need to log in
          before you can comment on or make changes to this bug.