Closed
Bug 1142513
Opened 10 years ago
Closed 9 years ago
Move MODULE_OPTIMIZE_FLAGS to moz.build
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1186444
People
(Reporter: Ms2ger, Unassigned, Mentored)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
6.56 KB,
patch
|
gps
:
review-
|
Details | Diff | Splinter Review |
See <https://mxr.mozilla.org/mozilla-central/search?string=MODULE_OPTIMIZE_FLAGS>. This would be similar to <https://hg.mozilla.org/mozilla-central/rev/61ae64c9aa0b>.
|
||
Comment 1•10 years ago
|
||
Attachment #8588346 -
Flags: review?(Ms2ger)
|
Reporter | |
Updated•10 years ago
|
Attachment #8588346 -
Flags: review?(Ms2ger) → review?(gps)
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8588346 [details] [diff] [review]
bug1142513.patch
Review of attachment 8588346 [details] [diff] [review]:
-----------------------------------------------------------------
While I understand why you would want to convert MODULE_OPTIMIZE_FLAGS to CFLAGS assignments, this conversion changes behavior. If you look in config/config.mk, you'll notice that MODULE_OPTIMIZE_FLAGS is conditionally used if MOZ_OPTIMIZE is defined.
What this patch does is convert -O appends from conditional to constant. This is almost certainly undesirable if people have explicitly disabled optimizations.
Attachment #8588346 -
Flags: review?(gps) → review-
|
||
Updated•9 years ago
|
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
|
||
Updated•7 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•