Closed Bug 1142525 Opened 9 years ago Closed 9 years ago

Implement adding context to conversations when a new conversation is started

Categories

(Hello (Loop) :: Client, defect, P1)

Product:
Hello (Loop)
Component:
Client
Type:
defect
Points:
2

Tracking

(firefox40 verified)

Status:
VERIFIED FIXED
Milestone:
mozilla40
Iteration:
40.1 - 13 Apr
Tracking Flags:
Tracking Status
firefox40 --- verified

People

(Reporter: standard8, Assigned: standard8)

References

(
URL
)

Details

(Whiteboard: [context])

User Story

https://bug1115341.bugzilla.mozilla.org/attachment.cgi?id=8563657

* A new panel tickbox allows adding context about the currently active tab when creating a new conversation 
* A thumbnail of the tab, the favicon of the active tab, the tab page title and tab URL are displayed besides the tickbox
* Creating a new conversation when having this new panel tickbox selected creates a conversation with metadata allowing to recover the thumbnail, favicon, page title and URL of the page when accessing the conversation from the desktop client or the standalone client
* The tickbox is disabled by default

Attachments

(1 file)

Hook up the tab context view to the create room action so that context can actually be added to a room.
26.66 KB, patch
mikedeboer
: review+
Details | Diff | Splinter Review 
When starting a new conversation, the user should be presented with the ability to add context. See the user story for more information.
Rank: 5
Flags: qe-verify+
Flags: firefox-backlog+
Priority: -- → P1
Whiteboard: [context]
Depends on: 1142687
Assignee: nobody → standard8
Iteration: --- → 40.1 - 13 Apr
Points: --- → 2
Little patch that depends on bug 1142522. This adds enough to get any selected context being added to the room on creation and saving it to the server in encrypted format.

I've tested this with debugging the despatcher and looking for the updateRoomList actions and checking the values in the array when I create a room, and subsequently when I restart a room.

Visuals for this are hooked up in other bugs in the dependency tree from bug 1115340.
Attachment #8590845 - Flags: review?(mdeboer)
Comment on attachment 8590845 [details] [diff] [review]
Hook up the tab context view to the create room action so that context can actually be added to a room.

Review of attachment 8590845 [details] [diff] [review]:
-----------------------------------------------------------------

I like it! Thanks.

::: browser/components/loop/content/js/roomStore.js
@@ +262,5 @@
>        });
>  
>        var roomCreationData = {
>          decryptedContext: {
> +          roomName:  this._generateNewRoomName(actionData.nameTemplate),

nit: trailing comma.
Attachment #8590845 - Flags: review?(mdeboer) → review+
https://hg.mozilla.org/integration/fx-team/rev/5a26c1f65709
Target Milestone: --- → mozilla40
For qe-verify:

This is part of the work for context in conversations and can't be tested until bug 1142588 or bug 1142514 have landed - as you won't be able to see the output.

At the moment the context in conversations work is hidden behind a pref and requires the dev server to run (until bug 1153806 is fixed), i.e. the prefs (suggest a separate profile):

loop.contextInConverations.enabled;true
loop.server;https://loop-dev.stage.mozaws.net/v0

- Once this is done, if you are visiting a non-browser page (i.e. not the start page, or about:config or something), then you should have an option when starting a conversation to select a tick box to add details of the current page to the conversation.

After the bugs mentioned at the start are implemented, you'll be able to see the output in various locations.
QA Contact: bogdan.maris
Will go ahead and close this as verified fixed because the layout was changed based on bug 1162905. Also dropping qe-verify+.
Status: RESOLVED → VERIFIED
status-firefox40: fixed → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: