114255 - nsRenderingContextGTK::CreateDrawingSurface doesn't always call UpdateGC

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[Bradley Baetz (:bbaetz)]

nsRenderingContextGTK::CreateDrawingSurface has:

if (!mGC)
  UpdateGC();

The problem with this is that if we change the clip region, then create a
drawing surface (using mGC as the GC), this new X pixmap will have the old clip
region associated with it.

Since clip regions are inherited, and you have to explicitly reset them to
(0,0,width,height) when drawing to an nsIDrawingSurface (which is apparently not
a bug), this causes problems if the drawing surface's origin is not (0,0)

That if statement has been in there since the original GCCache stuff went in
almost two years ago, and Stuart can't remember why.

patch coming up.

Comment 1

[Bradley Baetz (:bbaetz)]

Attachment: patch

Comment 2

[Stuart Parmenter]

Comment on attachment 60971 [details] [diff] [review]
patch

r=pavlov

Comment 3

[Johnny Stenback (:jst)]

Comment on attachment 60971 [details] [diff] [review]
patch

sr=jst

Comment 4

[Bradley Baetz (:bbaetz)]

Checked in.

Comment 5

[Roland Mainz]

Filed bug 114334 to port the patch to the Xlib gfx land ...