114334 - [Xlib] Need port of bug 114255 to Xlib-toolkit

Status: RESOLVED FIXED

(Core :: XUL, enhancement)

Description

[Roland Mainz]

Need a port of patch in bug 114255 ("nsRenderingContextGTK::CreateDrawingSurface
doesn't always call UpdateGC") to Xlib toolkit.

Comment 1

[Roland Mainz]

Attachment: Patch for 2001-11-30-08-trunk

Comment 2

[timeless]

Comment on attachment 61032 [details] [diff] [review]
Patch for 2001-11-30-08-trunk

i really wish the logic here
+  if (!((aBounds->width > 0) && (aBounds->height > 0)))
was inverted, but oh well.

Comment 3

[kinmoz]

Comment on attachment 61032 [details] [diff] [review]
Patch for 2001-11-30-08-trunk

Put the brace back up near the "if" to match the rest of the file and that
function.

Do we have to worry about mGC being null after UpdateGC()? I noticed that the
surf->Init() call doesn't check mGC before it uses it.

sr=[e-mail]

Comment 4

[kinmoz]

Btw, I agree with timeless:

  +  if (aBounds->width <= 0 || aBounds->height <= 0)

is much easier to read at a quick glance.

Comment 5

[Roland Mainz]

Attachment: New patch for 2001-12-09-08-trunk to match sr=kin

Comment 6

[Roland Mainz]

bz:
Wanna check this "in", please ?

Comment 7

[Boris Zbarsky [:bzbarsky]]

checked in