1142765 - Schedule Android 4.0 Debug xpcshell tests on all trunk trees and let them ride the trains

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Geoff Brown [:gbrown]]

+++ This bug was initially created as a clone of Bug #1030753 +++

Android 4.0 Debug xpcshell tests can now be run on trunk trees.

(mochitest-gl, robocop and cppunit tests are still not green / not ready for trunk)


I have a tentative 2015 Q2 goal to move Android Debug tests to the Android 4.3 emulator and retire the Android 4.0 Debug tests, but at this point I don't know how long that will take, or even if it will be possible. xpcshell tests are green on Cedar now, so it would be nice to get them running on trunk to avoid losing ground, but if it is a lot of work, we can certainly delay or wontfix this.

Comment 1

[Kim Moir [:kmoir] ET]

Attachment: bug1142765.patch

will attach builderdiff

Comment 2

[Kim Moir [:kmoir] ET]

Attachment: bug1142765builder.diff

builder diff

Comment 3

[Jordan Lund (:jlund)]

Comment on attachment 8577334 [details] [diff] [review]
bug1142765.patch

Review of attachment 8577334 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm. I suspect you only want to change trunk at the moment so I'm going to r- for now. bear with me if I'm wrong :)

::: mozilla-tests/mobile_config.py
@@ +1741,5 @@
>                          BRANCHES[name]['platforms'][platform][slave_plat]['debug_unittest_suites'] = deepcopy(ANDROID_MOZHARNESS_MOCHITEST + ANDROID_MOZHARNESS_JSREFTEST + ANDROID_MOZHARNESS_CRASHTEST + ANDROID_MOZHARNESS_PLAIN_REFTEST)
>  
> +# Bug 1142765 - Schedule Android 4.0 Debug xpcshell tests on 
> +# all trunk trees and let them ride the trains 
> +for name, branch in items_at_least(BRANCHES, 'gecko_version', 38):

your builderdiff included m-a. do we want s/38/39 here ?

@@ +1750,5 @@
> +        if not platform in PLATFORMS:
> +            continue
> +        if platform not in ('android-api-11'):
> +            continue
> +        #print "hello", platform

debug line?

@@ +1760,5 @@
> +            if not branch['platforms'][platform][slave_plat]['debug_unittest_suites']:
> +                continue
> +            if branch['platforms'][platform]['enable_debug_unittests'] is True:
> +                for type in branch['platforms'][platform][slave_plat]:
> +                    if 'debug_unittest_suite' in type:

above you have:

if not branch['platforms'][platform][slave_plat]['debug_unittest_suites']:

do we need the current for loop and condition here?

@@ +1761,5 @@
> +                continue
> +            if branch['platforms'][platform]['enable_debug_unittests'] is True:
> +                for type in branch['platforms'][platform][slave_plat]:
> +                    if 'debug_unittest_suite' in type:
> +                        BRANCHES[name]['platforms'][platform][slave_plat]['debug_unittest_suites'] = deepcopy(ANDROID_MOZHARNESS_MOCHITEST + ANDROID_MOZHARNESS_JSREFTEST + ANDROID_MOZHARNESS_CRASHTEST + ANDROID_MOZHARNESS_PLAIN_REFTEST + ANDROID_MOZHARNESS_XPCSHELL)

so iiuc, if http://mxr.mozilla.org/build/source/buildbot-configs/mozilla-tests/mobile_config.py?rev=3c76bc12cb25#1721 were to change, this would have to be updated too as it overwrites things for trunk branches? I guess that's not really a big issue as it is likely not going to change and builderlists will catch future patch mistakes.

Comment 4

[Kim Moir [:kmoir] ET]

Attachment: bug1142765-2.patch

patch with fixes suggested by review

Comment 5

[Kim Moir [:kmoir] ET]

Attachment: bug1142765builder-2.diff

builder diff 

I don't like that the way that the tests are overwritten but couldn't think of a better solution.

Comment 6

[Kim Moir [:kmoir] ET]

Attachment: bug1142765-3.patch

Comment 7

[Jordan Lund (:jlund)]

Comment on attachment 8578181 [details] [diff] [review]
bug1142765-3.patch

Review of attachment 8578181 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm :)

Comment 8

[Jordan Lund (:jlund)]

In production: https://hg.mozilla.org/build/buildbot-configs/rev/bd1582014509

Comment 9

[Kim Moir [:kmoir] ET]

verified on treeherder