Closed
Bug 1142829
Opened 10 years ago
Closed 10 years ago
[Hacker Marketplace] Use gaia-button instead of styling button elements
Categories
(Firefox OS Graveyard :: Gaia, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: mikehenrty, Assigned: mikehenrty)
References
()
Details
(Whiteboard: [spark])
Attachments
(1 file)
Right now the buttons don't look so good in hackerplace. However, gaia buttons are too tall and we can't change the font size. For now, I'll fork gaia-button and expose those props via css vars. But I will also submit a PR against gaia-buttons so we can eventually use master.
|
Assignee | |
Comment 1•10 years ago
|
||
Attachment #8577018 -
Flags: review?(dsherk)
|
|
Assignee | |
Updated•10 years ago
|
Assignee: nobody → mhenretty
|
||
Comment 2•10 years ago
|
||
Comment on attachment 8577018 [details] [review]
[PR] use gaia-button (a fork for now)
I left some comments on the PR. It'll be helpful when your changes actually arrive in the gaia-button repo as I'm having similar problems with it in the Sharing app.
Attachment #8577018 -
Flags: review?(dsherk) → review+
|
|
Assignee | |
Comment 3•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
||
Updated•10 years ago
|
Whiteboard: [lightsaber] → [ignite]
|
|
||
Updated•10 years ago
|
Whiteboard: [ignite] → [spark]
You need to log in
before you can comment on or make changes to this bug.
Description
•