1143032 - Reading List icon in overflow menu too large

Status: RESOLVED WONTFIX

(Firefox for Android Graveyard :: Theme and Visual Design, defect)

Description

[Paul [pwd]]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:39.0) Gecko/20100101 Firefox/39.0
Build ID: 20150312145801

Steps to reproduce:

In being the same height as the bookmark icon, it's that much larger, it should probably be the same width rather than the same height.

Comment 1

[Aaron Train [:aaronmt]]

Screenshot?

Comment 2

[Paul [pwd]]

Attachment: tmp_14130-Screenshot_2015-03-13-17-43-06238248610.png

Comment 3

[:Margaret Leibovic]

Mike, known issue?

Comment 4

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Anthony, is this the expected design?

Comment 5

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to Paul [pwd] from comment #0)
> User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:39.0) Gecko/20100101
> Firefox/39.0
> Build ID: 20150312145801
> 
> Steps to reproduce:
> 
> In being the same height as the bookmark icon, it's that much larger, it
> should probably be the same width rather than the same height.

Thanks for filing this pwd! I actually tried that early on but making the width the same makes it awkwardly small. 

This icon re-uses the same asset as the Reader View controls and I think it actually looks pretty good across different devices. Though, it definitely could use a bit more breathing space. I think the solution (to be a part of bug 1140169) would be to increase each item's height to 48dp - therefore giving it more room.

WONTFIXING this for reasons mentioned above.

Comment 6

[Paul [pwd]]

(In reply to Anthony Lam (:antlam) from comment #5)
> (In reply to Paul [pwd] from comment #0)
> > User Agent: Mozilla/5.0 (X11; Ubuntu; Linux i686; rv:39.0) Gecko/20100101
> > Firefox/39.0
> > Build ID: 20150312145801
> > 
> > Steps to reproduce:
> > 
> > In being the same height as the bookmark icon, it's that much larger, it
> > should probably be the same width rather than the same height.
> 
> Thanks for filing this pwd! I actually tried that early on but making the
> width the same makes it awkwardly small. 
> 
> This icon re-uses the same asset as the Reader View controls and I think it
> actually looks pretty good across different devices. Though, it definitely
> could use a bit more breathing space. I think the solution (to be a part of
> bug 1140169) would be to increase each item's height to 48dp - therefore
> giving it more room.
> 
> WONTFIXING this for reasons mentioned above.

I'm not sure making them all 48dp is the answer.

See:
http://www.dadapixel.com/blog/2015/1/22/why-fuzzy-geometry-sometimes-works-in-visual-design
and
http://en.wikipedia.org/wiki/Area_density