1143105 - remove unnecessary nsISSLErrorListener implementations in comm-central

Status: RESOLVED FIXED

(MailNews Core :: Security, defect)

Description

[Dana Keeler (she/her) (use needinfo) [:keeler]]

nsISSLErrorListener is obsolete and will be removed in bug 844351. The implementations in comm-central don't do anything and can be removed.

Comment 1

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Attachment: patch

David, would you mind reviewing this? Thanks.

Comment 2

[Patrick Cloke [:clokep]]

Comment on attachment 8577430 [details] [diff] [review]
patch

I don't believe David is doing many reviews anymore, redirecting to Joshua (rkent might be a choice also). This also needs a chat peer review, although it looks fairly straightforward.

Comment 3

[Patrick Cloke [:clokep]]

Comment on attachment 8577430 [details] [diff] [review]
patch

Review of attachment 8577430 [details] [diff] [review]:
-----------------------------------------------------------------

The chat/ changes look good. Thanks for providing the patch! :)

Comment 4

[Joshua Cranmer [:jcranmer]]

Comment on attachment 8577430 [details] [diff] [review]
patch

Review of attachment 8577430 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not sure that this is the best solution, but our SSL cert error story has gotten pretty bad, and it doesn't look like this makes things any worse.

But thanks for considering comm-central! If only more people were as kind as you. :-)

Comment 5

[Dana Keeler (she/her) (use needinfo) [:keeler]]

Thanks for the reviews!
Try: https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=cbaa4039d806

Comment 6

[Dana Keeler (she/her) (use needinfo) [:keeler]]

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=cbaa4039d806

Comment 7

[Philipp Kewisch [:Fallen][📱📆]]

Pushed to comm-central changeset b46e9e6c9454

Comment 8

[Ben Bucksch (:BenB)]

Why did you not use what bsmith suggested in bug 844351? He specifically says:

16:37         bsmith | ... how
                     | thunderbird should replace its nsISSLErrorListener
                     | implementation
16:38         bsmith | When you create a channel, you pass in some callbacks
16:38         bsmith | and one of the callbacks is a callback that gets called
                     | when the channel is closed
16:38         bsmith | and that callback gets the nsresult for the channel
16:38         bsmith | which you can convert into an NSS error code using the
                     | various PSM functions for doing so