remove unnecessary nsISSLErrorListener implementations in comm-central

RESOLVED FIXED in Thunderbird 39.0

Status

MailNews Core
Security
RESOLVED FIXED
3 years ago
a year ago

People

(Reporter: keeler, Assigned: keeler)

Tracking

unspecified
Thunderbird 39.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

nsISSLErrorListener is obsolete and will be removed in bug 844351. The implementations in comm-central don't do anything and can be removed.
Created attachment 8577430 [details] [diff] [review]
patch

David, would you mind reviewing this? Thanks.
Assignee: nobody → dkeeler
Status: NEW → ASSIGNED
Attachment #8577430 - Flags: review?(mozilla)
Comment on attachment 8577430 [details] [diff] [review]
patch

I don't believe David is doing many reviews anymore, redirecting to Joshua (rkent might be a choice also). This also needs a chat peer review, although it looks fairly straightforward.
Attachment #8577430 - Flags: review?(mozilla)
Attachment #8577430 - Flags: review?(clokep)
Attachment #8577430 - Flags: review?(Pidgeot18)
Comment on attachment 8577430 [details] [diff] [review]
patch

Review of attachment 8577430 [details] [diff] [review]:
-----------------------------------------------------------------

The chat/ changes look good. Thanks for providing the patch! :)
Attachment #8577430 - Flags: review?(clokep) → review+
Comment on attachment 8577430 [details] [diff] [review]
patch

Review of attachment 8577430 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not sure that this is the best solution, but our SSL cert error story has gotten pretty bad, and it doesn't look like this makes things any worse.

But thanks for considering comm-central! If only more people were as kind as you. :-)
Attachment #8577430 - Flags: review?(Pidgeot18) → review+
Pushed to comm-central changeset b46e9e6c9454
Status: ASSIGNED → RESOLVED
Last Resolved: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 39.0
Why did you not use what bsmith suggested in bug 844351? He specifically says:

16:37         bsmith | ... how
                     | thunderbird should replace its nsISSLErrorListener
                     | implementation
16:38         bsmith | When you create a channel, you pass in some callbacks
16:38         bsmith | and one of the callbacks is a callback that gets called
                     | when the channel is closed
16:38         bsmith | and that callback gets the nsresult for the channel
16:38         bsmith | which you can convert into an NSS error code using the
                     | various PSM functions for doing so
You need to log in before you can comment on or make changes to this bug.