Closed Bug 844351 Opened 7 years ago Closed 5 years ago
nsIWebProgressListener should be used instead, or not at all.
16:35 bsmith | keeler: using nsIWebProgressListener works for people | that are listening for web content loads (loads that | occur in docshells) 16:37 bsmith | keeler: But, there are also loads that don't occur in | docshells, like what thunderbird does. 16:37 bsmith | So, you might get some people asking you to explain how | thunderbird should replace its nsISSLErrorListener | implementation 16:38 bsmith | When you create a channel, you pass in some callbacks 16:38 bsmith | and one of the callbacks is a callback that gets called | when the channel is closed 16:38 bsmith | and that callback gets the nsresult for the channel 16:38 bsmith | which you can convert into an NSS error code using the | various PSM functions for doing so 16:39 bsmith | I think nsIDocShell deals with errors that way. 16:39 bsmith | I remember that if you look in Thunderbird's IMAP | implementation, they already handle errors that way 16:39 bsmith | for non-SSL stuff. 16:40 bsmith | So, they basically just need to add more cases to their | switch statement to handle the SSL- and Cert- related | errors
7 years ago
Depends on: 846581
Doesn't look like this depends on bug 846581 anymore. As far as I can tell, there's nothing still using this interface for anything meaningful. (There are some uses in comm-central, but the implementations don't actually do anything.)
No longer depends on: 846581
5 years ago
Depends on: 1143105
5 years ago
Depends on: 1143110
Posted a notification that this is going away: https://groups.google.com/forum/#!topic/mozilla.dev.platform/AnRVB_DEcyA
ni Jorge in case this needs to be documented for add-on compat. I don't know the timeline for this change but it was announced on dev-platform this week.
A few add-ons seem to use it, but it doesn't look like a big concern. Flagging for future documentation.
Cykesiopka - would you mind reviewing this? Thanks.
Assignee: nobody → dkeeler
Status: NEW → ASSIGNED
Attachment #8584813 - Flags: review?(cykesiopka.bmo)
Comment on attachment 8584813 [details] [diff] [review] patch Review of attachment 8584813 [details] [diff] [review]: ----------------------------------------------------------------- LGTM.
Attachment #8584813 - Flags: review?(cykesiopka.bmo) → review+
You need to log in before you can comment on or make changes to this bug.