1143110 - remove unnecessary nsISSLErrorListener implementation in chatzilla

Status: RESOLVED FIXED

(Other Applications Graveyard :: ChatZilla, defect)

Description

[Dana Keeler (she/her) [:keeler]]

nsISSLErrorListener is obsolete and will be removed in bug 844351. The implementation in chatzilla don't do anything and can be removed.

Comment 1

[Dana Keeler (she/her) [:keeler]]

Attachment: patch

Gijs, would you mind reviewing this? Thanks.

Comment 2

[:Gijs (he/him)]

Comment on attachment 8577424 [details] [diff] [review]
patch

Review of attachment 8577424 [details] [diff] [review]:
-----------------------------------------------------------------

r+ because this was apparently non-functional since at least December 2011: http://hg.mozilla.org/mozilla-central/pushloghtml?changeset=7cd14fbf2789 which is a few ESRs ago

Comment 3

[Dana Keeler (she/her) [:keeler]]

Thanks! What's the process for checking in to chatzilla? (should I just mark this checkin-needed?)

Comment 4

[:Gijs (he/him)]

(In reply to David Keeler [:keeler] (use needinfo?) from comment #3)
> Thanks! What's the process for checking in to chatzilla? (should I just mark
> this checkin-needed?)

I believe that if you can push to m-c (integration), then you should be able to push to chatzilla's repo, too. If you prefer, I can also land this for you (but please say so).

Comment 5

[Dana Keeler (she/her) [:keeler]]

Ok - pushed:
https://hg.mozilla.org/chatzilla/rev/f8e44816adce

Thanks!