Closed
Bug 1143168
Opened 11 years ago
Closed 11 years ago
Audit puppet code for secrets in diffs
Categories
(Infrastructure & Operations :: RelOps: Puppet, task)
Infrastructure & Operations
RelOps: Puppet
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: dustin, Assigned: dustin)
Details
Attachments
(1 file, 1 obsolete file)
|
5.35 KB,
patch
|
markco
:
review+
dustin
:
checked-in+
|
Details | Diff | Splinter Review |
Search and fix any templates or other uses of secrets that do not take precautions to avoid including the secret in the puppet report. In general, that means using file { show_diff => false }.
|
Assignee | |
Comment 1•11 years ago
|
||
Flagging some f? for folks whose puppet code is affected.
Attachment #8584002 -
Flags: review?(mcornmesser)
Attachment #8584002 -
Flags: feedback?(jvehent)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8584002 -
Flags: feedback?(catlee)
|
|
Assignee | |
Updated•11 years ago
|
Attachment #8584002 -
Flags: feedback?(arich)
|
|
Assignee | |
Comment 2•11 years ago
|
||
As catlee pointed out, I meant show_diff => false!
Attachment #8584002 -
Attachment is obsolete: true
Attachment #8584002 -
Flags: review?(mcornmesser)
Attachment #8584002 -
Flags: feedback?(jvehent)
Attachment #8584002 -
Flags: feedback?(catlee)
Attachment #8584002 -
Flags: feedback?(arich)
Attachment #8584004 -
Flags: review?(mcornmesser)
|
||
Updated•11 years ago
|
Attachment #8584004 -
Flags: review?(mcornmesser) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 8584004 [details] [diff] [review]
bug1143168-false.patch
remote: https://hg.mozilla.org/build/puppet/rev/33fe03e828f9
remote: https://hg.mozilla.org/build/puppet/rev/c517f2e27b04
Attachment #8584004 -
Flags: checked-in+
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•