114321 - hreflang handling broken in site navigation bar (links toolbar)

Status: RESOLVED FIXED

(SeaMonkey :: UI Design, defect, P2)

Description

[Tobias Burnus]

Hi

If I read the spec correctly (URL) than the link type are case sensitive.
Using lowercase types (in the HTML 4.01 spec they are lowcase with exception of
the first letter) in XHTML doesn't work.

Testcase: http://www.physik.fu-berlin.de/~fsi/

I couldn't find anything in the XHTML spec that says that they have to be
case-sensitive.

Comment 1

[Tobias Burnus]

s/link type are case sensitive/link type are case insensitive/
                                                  ^^

Comment 2

[Boris Zbarsky [:bzbarsky]]

Nothing to do with case.  We already lowecase all the rel and rev attr values in
that code.

The code to do mapping for hreflang attributes was broken -- it was using getKey
and getValue instead of .key and .value

Tim or Stuart, would you review the upcoming patch?

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: The fix

Comment 4

[Tim 'Tool-Man' Taylor]

r=Tim

I'm not authorized to edit attachments, so I can't update the patch's status to
"has review"

Comment 5

[Boris Zbarsky [:bzbarsky]]

*** Bug 116890 has been marked as a duplicate of this bug. ***

Comment 6

[Boris Zbarsky [:bzbarsky]]

resummarizing so I can find it.  :)

Comment 7

[Boris Zbarsky [:bzbarsky]]

*** Bug 117731 has been marked as a duplicate of this bug. ***

Comment 8

[jag (Peter Annema)]

Comment on attachment 61017 [details] [diff] [review]
The fix

sr=jag

Comment 9

[[e-mail] (gone - use [e-mail] instead)]

Checked in.