1143298 - Firefox Hello Contact Import Issue

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect)

Description

[reinhart_previano]

Attachment: The app said that it had imported 36 contacts, while I still see only two imported contacts there.

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Firefox/38.0
Build ID: 20150313004057

Steps to reproduce:

In a window, I clicked on the Firefox Hello icon, then I navigate to Contacts app, then I clicked Import. My Firefox have been logged in to Google Account, so I proceed to the App Permissions page. At last, I clicked the Accept button there.


Actual results:

The app said that it had imported 36 contacts, while I still see only two imported contacts there.


Expected results:

The app should be able to show 36 contacts on the app.

Comment 1

[Mike de Boer [:mikedeboer]]

Reinhart, thanks for reporting this!

The two imported contacts are actually expected, instead of the full 36. This is because the contacts you'd like to see in Hello have to be part of the 'Contacts' group. You can see this in the 'Contacts' section in GMail.

The thing is that we're reporting the wrong number! I'll fix that asap.

Comment 2

[Mike de Boer [:mikedeboer]]

Attachment: Patch v1: show the correct amount of imported contacts

Comment 3

[reinhart_previano]

The GMail contacts now are in http://contacts.google.com. Does it mean the contacts that appeared are using Firefox Account or Persona Account and ever connected it to Hello?

Comment 4

[reinhart_previano]

About the two same "Reinhart" contacts, actually, it has more than one email accounts.

Comment 5

[Mark Banner (:standard8)]

Comment on attachment 8578080 [details] [diff] [review]
Patch v1: show the correct amount of imported contacts

Review of attachment 8578080 [details] [diff] [review]:
-----------------------------------------------------------------

Not tested, but code inspection reveals this is the right thing to do.

I suspect we probably want to uplift this to aurora as well.

Comment 6

[Mike de Boer [:mikedeboer]]

Thanks!

Pushed to fx-team as: https://hg.mozilla.org/integration/fx-team/rev/f2ff4f629170

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/f2ff4f629170

Comment 8

[Mike de Boer [:mikedeboer]]

Comment on attachment 8578080 [details] [diff] [review]
Patch v1: show the correct amount of imported contacts

Approval Request Comment
[Feature/regressing bug #]: Firefox Hello Google contacts import
[User impact if declined]: The import process currently reports the incorrect number of contacts that were _actually_ imported. This patch fixes this so that the number reported always reflects the amount of contacts added to the contacts list in the UI.
[Describe test coverage new/current, TreeHerder]: landed on m-c, tests pass.
[Risks and why]: minor.
[String/UUID change made/needed]: n/a.

Comment 9

[Mike de Boer [:mikedeboer]]

Comment on attachment 8578080 [details] [diff] [review]
Patch v1: show the correct amount of imported contacts

Cancelling beta approval request, since bug 1076764 is only available for Aurora/ Fx 38 and later.

Comment 10

[Raul Nicolae Malea]

Error for me:

401. That’s an error.

Error: invalid_client

The OAuth client was not found.
Request Details

    scope=https://www.google.com/m8/feeds
    response_type=code
    redirect_uri=urn:ietf:wg:oauth:2.0:oob:auto
    client_id=no-google-oauth-api-clientid

That’s all we know.

Nightly, openSUSE 13.2

Comment 11

[Mark Banner (:standard8)]

(In reply to Raul Malea from comment #10)
> Error for me:
> 
> 401. That’s an error.
> 
> Error: invalid_client

That's bug 1106854.

Comment 12

[Raul Nicolae Malea]

(In reply to Mark Banner (:standard8) from comment #11)
> (In reply to Raul Malea from comment #10)
> > Error for me:
> > 
> > 401. That’s an error.
> > 
> > Error: invalid_client
> 
> That's bug 1106854.

Thank you very much! :)

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/4a3cc0e9fca5

Comment 14

[reinhart_previano]

OK I can see it is fixed now.