1076764 - Implement contacts import success and error reporting

Status: RESOLVED FIXED

(Hello (Loop) :: Client, defect, P2)

Description

[Mike de Boer [:mikedeboer]]

The UX flow specified by bug 1076762 needs to be implemented.

Comment 1

[Matthew N. [:MattN]]

In bug 1076762 comment 1, Darrin mentioned not notifying on success.

Comment 2

[:shell escalante]

this bug work was broken down (so meta), the last action (replacing generic error with helpful one) is on but 1076762

Comment 3

[Maire Reavy [:mreavy]]

[Tracking Requested - why for this release]:
We need to finish off success and error reporting for importing contacts

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Not critical enough to be tracked for the 36 release.

Comment 5

[Maire Reavy [:mreavy]]

Moving all P1->P2.  (P2 means a major bug that we very much want to fix, but we wouldn't stop ship or block the release for it.)

Comment 6

[Maire Reavy [:mreavy]]

Here's the actual change from P1->P2 (per the previous comment).  P2 indicates a major bug, but not a stop ship.

Comment 7

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: Better error message on Loop contact import failure.

This is theoretical code, as I didn't find a proper way to simulate an import failure yet, hence just asking for feedback for now.

Comment 8

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

Attachment: Better error message on Loop contact import failure.

Added error and success notifications for contacts import.

Comment 9

[Mark Banner (:standard8)]

Comment on attachment 8549687 [details] [diff] [review]
Better error message on Loop contact import failure.

Review of attachment 8549687 [details] [diff] [review]:
-----------------------------------------------------------------

This looks great. r=Standard8.

My only concern was over the strings - I think we changed/added some strings in 36 for this bug, which were different to what is documented here :-( However, this is an improvement, so I think we should land it - I believe that any subsequent change would use the same architecture anyway. I'll file a follow-up to either switch to the new strings (which also has a button), or remove the now redundant strings.

Comment 10

[Mark Banner (:standard8)]

Filed bug 1122471 for the follow-up.

Comment 11

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

https://hg.mozilla.org/integration/fx-team/rev/4cd191478d41

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4cd191478d41

Comment 13

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Assigning to Paul for verification since Anthony no longer manages Loop.

Comment 14

[Paul Silaghi, QA [:pauly]]

I disabled the network adapter just before finalizing the last step from contacts importing:
http://i.imgur.com/hCowWcW.png - importing circle spins forever.
The "Some contacts could not be imported. Please try again." error shows up only after I close the import window.

Also the error shows up if canceling the last step from import. Not sure if this is expected, since I want to cancel the import, and the error says "Some contacts could not be imported".

Thoughts?

Comment 16

[Nicolas Perriault (:NiKo`) — needinfo me if you need my attention]

(In reply to Paul Silaghi, QA [:pauly] from comment #14)
> Thoughts?

It feels like the issue resides in chrome-land, where the import process is actually performed. Content only subscribes to success/error notification using a callback and the latter seems to be triggered after the import window being closed.

NI :mikedeboer here which might have thoughts on this, and a possible solution.

Comment 17

[Mike de Boer [:mikedeboer]]

Paul, feel free to file a bug on this. It's not likely we'll work on a solution for that case soon, but it's at least useful to have a reference that this issue exists.

Comment 18

[Vasilica Tamas, QA [:vtamas]]

(In reply to Paul Silaghi [:pauly] from comment #14)

Based on Paul's comment and on my testing I logged two issues:
 
> I disabled the network adapter just before finalizing the last step from
> contacts importing:
> http://i.imgur.com/hCowWcW.png - importing circle spins forever.
> The "Some contacts could not be imported. Please try again." error shows up
> only after I close the import window.

Bug 1144734 - The "Some contacts could not be imported. Please try again." error shows up only after the import window is closed

> Also the error shows up if canceling the last step from import. Not sure if
> this is expected, since I want to cancel the import, and the error says
> "Some contacts could not be imported".

Bug 1144739 - Improper error message if the importing contacts is canceled