114349 - drawing surfaces are 1 pixel off on height/width

Status: VERIFIED DUPLICATE of bug 10090

(Core :: Layout, defect)

Description

[Paul]

I think this might be in the drawing surface.  The windows are created with the proper size, but the drawing surface on the views within the window are 1 pixel too small in both height and width.  This was fine, until sometime in September or early October.  At that point, I had not gotten an update in a while, since I was working on something else.  I think there may have been some graphics optimizations done, which broke things under BeOS.  I am going to start looking into this in more detail, but wanted to create a bug for it first.

If anyone has some helpful hints to point me in the right direction, please let me know.

Comment 1

[sairuh (rarely reading bugmail)]

layout?

Comment 2

[Paul]

I've been looking into this.  If some optimizations were done, I think
one thing they did was to change what the values for the bounds of
a widget mean.  Under BeOS, a view(widget), that is 4x4 would have the
uppder left coordinates of 0,0 and the lower right of 3,3.  The width for
the view would be returned as the right-left, or 3.  This is were the problem
I believe lies, but doing some quick changes does not seem to help.  Plus,
I think there are problems within both nsWindow.cpp and nsRenderContextBeOS.cpp.


I'm getting closer, but, finding it difficult to figure out what exactly
Mozilla wants for it's values.  I was able to make it worse, at one point, i.e.
2 pixels off.  I just have to figure out what I did, and reverse it. :)

Oh well, more digging ...

Comment 3

[Daniel Switkin]

See my comments here:

http://bugzilla.mozilla.org/show_bug.cgi?id=10090

The main problem is in nsRegionBeOS :: GetBoundingBox(), which needs to add one to the 
width and height.

If someone else here has cvs access I'll mail you my changes and you can commit them.

Comment 4

[Paul]

I do have CVS access, so, if you mail me the changes, I'll make up a patch, and attach to this bug.  Once the patch is reviewed, I can then commit it.I have also marked a dependency to Bug#10090

Comment 5

[Paul]

Oops, I didn't mean dependency, I should have marked as duplicate, which I will do ...

*** This bug has been marked as a duplicate of 10090 ***

Comment 6

[Kai Lahmann (is there, where MNG is)]

v