1143860 - Deduplicate tracked optimizations in JSON

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Shu-yu Guo [:shu]]

Right now, tracked optimizations are streamed as part of the frame they're attached to. This results in a lot of duplicates and a big JSON for JS-heavy programs (tried on octane).

They should be deduplicated.

Comment 1

[Shu-yu Guo [:shu]]

Attachment: Add column number to PCToLineNumber.

Comment 2

[Shu-yu Guo [:shu]]

Attachment: Deduplicate tracked optimizations when streaming the profile.

Comment 3

[Kannan Vijayan [:djvj]]

Comment on attachment 8578253 [details] [diff] [review]
Deduplicate tracked optimizations when streaming the profile.

Review of attachment 8578253 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/profiler/ProfileEntry.h
@@ +90,5 @@
> +    bool operator<(const OptimizationKey& other) const;
> +  };
> +
> +  mozilla::Vector<OptimizationKey> mOpts;
> +  std::map<OptimizationKey, unsigned> mOptToIndexMap;

unordered_map (formerly hash_map) might be a better option here since we don't really care about ordering, just using the map to implement a cache.

Comment 4

[Shu-yu Guo [:shu]]

(In reply to Kannan Vijayan [:djvj] from comment #3)
> Comment on attachment 8578253 [details] [diff] [review]
> Deduplicate tracked optimizations when streaming the profile.
> 
> Review of attachment 8578253 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: tools/profiler/ProfileEntry.h
> @@ +90,5 @@
> > +    bool operator<(const OptimizationKey& other) const;
> > +  };
> > +
> > +  mozilla::Vector<OptimizationKey> mOpts;
> > +  std::map<OptimizationKey, unsigned> mOptToIndexMap;
> 
> unordered_map (formerly hash_map) might be a better option here since we
> don't really care about ordering, just using the map to implement a cache.

I was told unordered_map isn't in enough places yet for us to use it.

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1b0a6e932bfb
https://hg.mozilla.org/mozilla-central/rev/44c06482dc74