1143879 - Implement lang member of Web manifest

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Marcos Caceres [:marcosc]]

It would be nice to support the `lang` attribute of web manifest.

Comment 1

[Marcos Caceres [:marcosc]]

Attachment: 0001-Bug-1143879-Implement-lang-member-of-Web-manifest.patch

For your reviewing pleasure :)

Comment 2

[Marcos Caceres [:marcosc]]

Attachment: Added todo tests for canonicalization of language tags.

Comment 3

[Marcos Caceres [:marcosc]]

Attachment: Fixed typos, enhanced test descriptions

Comment 4

[(no longer active)]

Comment on attachment 8606489 [details] [diff] [review]
Fixed typos, enhanced test descriptions

Review of attachment 8606489 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/manifest/ManifestProcessor.jsm
@@ +262,5 @@
> +        // API. This is currently the only crappy way to check for validity of
> +        // language tags:
> +        //   https://bugs.ecmascript.org/show_bug.cgi?id=4365
> +        try {
> +          Intl.Collator(tag);

Right now, we don't support the Intl API on Android (bug 864843), so we need to do something here which would work there too.  Perhaps passing the value trimmed is enough?

Comment 5

[Marcos Caceres [:marcosc]]

Attachment: Remove dependency on Intl API. Canonicalization and "is structurally valid" checks deferred to later as todos.

Comment 6

[Marcos Caceres [:marcosc]]

Attachment: Remove dependency on Intl API. Canonicalization and "is structurally valid" checks deferred to later as todos.

Comment 7

[Marcos Caceres [:marcosc]]

Try:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=373f23ea1923

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a96e3936c2cb

Comment 9

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/66896f9c0ebd

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a96e3936c2cb
https://hg.mozilla.org/mozilla-central/rev/66896f9c0ebd