Closed Bug 1143879 Opened 6 years ago Closed 6 years ago

Implement lang member of Web manifest

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: marcosc, Assigned: marcosc)

References

(Blocks 1 open bug, )

Details

(Keywords: dev-doc-needed)

Attachments

(1 file, 4 obsolete files)

It would be nice to support the `lang` attribute of web manifest.
Blocks: webmanifest
No longer depends on: webmanifest
For your reviewing pleasure :)
Attachment #8606055 - Flags: review?(ehsan)
Attachment #8606055 - Attachment is obsolete: true
Attachment #8606055 - Flags: review?(ehsan)
Attachment #8606481 - Flags: review?(ehsan)
Attachment #8606481 - Attachment is obsolete: true
Attachment #8606481 - Flags: review?(ehsan)
Attachment #8606489 - Flags: review?(ehsan)
Comment on attachment 8606489 [details] [diff] [review]
Fixed typos, enhanced test descriptions

Review of attachment 8606489 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/manifest/ManifestProcessor.jsm
@@ +262,5 @@
> +        // API. This is currently the only crappy way to check for validity of
> +        // language tags:
> +        //   https://bugs.ecmascript.org/show_bug.cgi?id=4365
> +        try {
> +          Intl.Collator(tag);

Right now, we don't support the Intl API on Android (bug 864843), so we need to do something here which would work there too.  Perhaps passing the value trimmed is enough?
Attachment #8606489 - Flags: review?(ehsan) → review-
Depends on: 864843
Assignee: nobody → mcaceres
Attachment #8608289 - Flags: review?(ehsan) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Depends on: 1164235
Keywords: checkin-needed
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/a96e3936c2cb
https://hg.mozilla.org/mozilla-central/rev/66896f9c0ebd
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Depends on: 1215247
Depends on: 1215252
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.