Closed Bug 1164235 Opened 6 years ago Closed 6 years ago

Add theme_color support to web manifest processor

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla41
Tracking Status
firefox41 --- fixed

People

(Reporter: marcosc, Assigned: marcosc)

References

(Blocks 1 open bug, )

Details

Attachments

(1 file, 1 obsolete file)

Add support for processing theme_color to web manifest, and generalize CSS color processing.
No longer depends on: 1162808
Assignee: nobody → mcaceres
Adds support for theme_color and generalizes color validation for background_color too.
Attachment #8605446 - Flags: review?(ehsan)
Comment on attachment 8605446 [details] [diff] [review]
0001-Bug-1164235-Add-theme_color-support-to-web-manifest-.patch

Review of attachment 8605446 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/manifest/ManifestValueExtractor.jsm
@@ +23,5 @@
> +
> +ManifestValueExtractor.prototype = {
> +  extractValue({
> +    expectedType, object, objectName, property, trim
> +  }) {

Can you please add a comment explaining what this is doing?
Attachment #8605446 - Flags: review?(ehsan) → review+
Keywords: checkin-needed
Blocks: 1143879
https://hg.mozilla.org/mozilla-central/rev/a90ab68fa412
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla41
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.