1164235 - Add theme_color support to web manifest processor

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Marcos Caceres [:marcosc]]

Add support for processing theme_color to web manifest, and generalize CSS color processing.

Comment 1

[Marcos Caceres [:marcosc]]

Attachment: 0001-Bug-1164235-Add-theme_color-support-to-web-manifest-.patch

Adds support for theme_color and generalizes color validation for background_color too.

Comment 2

[(no longer active)]

Comment on attachment 8605446 [details] [diff] [review]
0001-Bug-1164235-Add-theme_color-support-to-web-manifest-.patch

Review of attachment 8605446 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/manifest/ManifestValueExtractor.jsm
@@ +23,5 @@
> +
> +ManifestValueExtractor.prototype = {
> +  extractValue({
> +    expectedType, object, objectName, property, trim
> +  }) {

Can you please add a comment explaining what this is doing?

Comment 3

[Marcos Caceres [:marcosc]]

Attachment: Added comment on what valueExtractor does.

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a735b726e65d

Comment 4

[Marcos Caceres [:marcosc]]

Cancelled other try. New try: 
https://treeherder.mozilla.org/#/jobs?repo=try&revision=373f23ea1923

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a90ab68fa412

Comment 6

[Ekanan Ketunuti]

https://hg.mozilla.org/mozilla-central/rev/a90ab68fa412