test_attachProcess.html fails when running a standalone directory

RESOLVED FIXED in Firefox 39

Status

RESOLVED FIXED
4 years ago
2 months ago

People

(Reporter: jmaher, Assigned: jmaher)

Tracking

unspecified
Firefox 39
Dependency tree / graph

Firefox Tracking Flags

(firefox39 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
running:
./mach mochitest-chrome toolkit/devtools/server/tests/mochitest/

fails for me locally on linux64, it also fails when I try to run on try with --run-by-dir for mochitest-other.  This started a few weeks ago and I am finally looking into it.

I did find out one thing- when the browser is up for some time (>2 minutes, maybe less), this test will work.  What I did was load up the browser and run a single test, then waited a couple of minutes and changed the url to run the toolkit/devtools/server/tests/mochitest/ directory, it worked- also running the test individually works after the browser has been up for a couple of minutes.

Most likely this is a side effect of moving some initialization code off the main thread and to something which starts 60+ seconds later.

I would like to get this fixed in the near future or else I will have to disable it until folks have more time to fix it.  Right now if we split tests into different chunks, this could cause all tests to fail.
(Assignee)

Comment 1

4 years ago
:ochameau, can you weigh in on this as you were the original patch author?
Depends on: 1060093
Flags: needinfo?(poirot.alex)
During the client attachProcess, this error occurs (and there are no promise reject handlers): "You are not allowed to debug chrome.". This is because DebuggerServer.allowChromeProcess is false.
(Assignee)

Comment 3

4 years ago
Created attachment 8579539 [details] [diff] [review]
add DebuggerServer.allowChromeProcess (1.0)

do let me know if I should set this to false at the end of the test case or do anything else.  This works for me locally.
Assignee: nobody → jmaher
Status: NEW → ASSIGNED
Flags: needinfo?(poirot.alex)
Attachment #8579539 - Flags: review?(jsantell)
Comment on attachment 8579539 [details] [diff] [review]
add DebuggerServer.allowChromeProcess (1.0)

Review of attachment 8579539 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/devtools/server/tests/mochitest/test_attachProcess.html
@@ +44,5 @@
>  
>    // Instantiate a minimal server
>    if (!DebuggerServer.initialized) {
>      DebuggerServer.init();
> +    DebuggerServer.allowChromeProcess = true;

Move this outside the if block, as in other examples[1].

[1]: https://dxr.mozilla.org/mozilla-central/source/toolkit/devtools/server/tests/unit/head_dbg.js#238
Attachment #8579539 - Flags: review?(jsantell) → review+
https://hg.mozilla.org/mozilla-central/rev/242dcd4086ff
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39

Updated

2 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.