Closed Bug 1144380 Opened 6 years ago Closed 6 years ago

active state on reading list sidebar persists after switching tabs

Categories

(Firefox Graveyard :: Reading List, defect)

defect
Not set
normal

Tracking

(firefox38 verified, firefox39 verified)

VERIFIED FIXED
Firefox 39
Tracking Status
firefox38 --- verified
firefox39 --- verified

People

(Reporter: clarkbw, Assigned: florian)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

STR:
* with the sidebar open select an item in the list to load the page in a tab
* switch tabs to another tab

Actually Results
- the active/selected state of the sidebar remains when viewing another tab that isn't displaying the article in the sidebar

Expected Results
- as you switch tabs away from the selected item the selection is cleared and vice versa
Flags: qe-verify+
OS: Mac OS X → All
Removing "selected" from the bug summary as in the sidebar code "selected" is used for the keyboard selection and "active" is used for the item currently shown in the selected tab.
Summary: selected/active state on reading list sidebar persists after switching tabs → active state on reading list sidebar persists after switching tabs
Attached patch Patch (obsolete) — Splinter Review
Assignee: nobody → florian
Status: NEW → ASSIGNED
Attachment #8580414 - Flags: review?(jaws)
Points: --- → 3
Flags: firefox-backlog+
Attachment #8580414 - Flags: review?(jaws) → review?(mhammond)
Iteration: --- → 39.2 - 23 Mar
Blocks: 1132074
QA Contact: andrei.vaida
Attachment #8580414 - Flags: review?(mhammond) → review+
Attached patch Patch v2Splinter Review
Made a small change so that the active item highlight is also removed when switching to a non http(s) tab (eg. about:newtab).
Attachment #8580414 - Attachment is obsolete: true
Attachment #8580837 - Flags: review?(mhammond)
Attachment #8580837 - Flags: review?(mhammond) → review+
https://hg.mozilla.org/mozilla-central/rev/1dca4f3d048d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
Verified fixed on Nightly 39.0a1 (2015-03-23), using Ubuntu 14.04 (x64), Mac OS X 10.9.5 and Windows 7 (x64).
Status: RESOLVED → VERIFIED
Verified fixed on Aurora 38.0a2 (2015-03-29) as well, using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.