1144465 - Text inside ruby is not bidi reordered

Status: RESOLVED FIXED

(Core :: Layout: Ruby, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

Bug 1141931 intends to fix bidi reordering of ruby frames themselves, but not the frames inside ruby base or ruby text.

Since rtl text is normally won't be put inside ruby, this bug is in lower priority.

Comment 3

[Xidorn Quan [:xidorn] UTC+10]

I have a working build now. Still need to do some more checking and testing, and clean up the code a bit.

Comment 4

[Xidorn Quan [:xidorn] UTC+10]

Attachment: Bug 1144465 - Resolve bidi inside ruby. r?jfkthame

This commit changes IsBidiLeaf to mark ruby boxes not a bidi leaf, since
conceptually they are not. I auditted all uses of it, and I believe it
makes more sense this way.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba1f9a1d9e6f
Resolve bidi inside ruby. r=jfkthame

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/20980 for changes under testing/web-platform/tests

Comment 7

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream web-platform-tests status checks passed, PR will merge once commit reaches central.

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/ba1f9a1d9e6f

Comment 9

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot