Secured ftp:// with authentication dialog box not working on E10S

RESOLVED FIXED in Firefox 42

Status

()

Core
Networking: FTP
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: Wellington Torrejais da Silva, Assigned: mrbkap)

Tracking

39 Branch
mozilla42
x86_64
Linux
Points:
---

Firefox Tracking Flags

(e10sm8+, firefox42 fixed)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Reporter)

Description

3 years ago
User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:39.0) Gecko/20100101 Firefox/39.0
Build ID: 20150312150027

Steps to reproduce:

On try to access ftp:// addresses:
ftp:// not working on E10S, black page is displayed but login windows not displayed


Actual results:

On try to access ftp:// addresses:
ftp:// not working on E10S, black page is displayed but login windows not displayed


Expected results:

Normal ftp:// access with browser on E10S
ftp works for me with latest Nightly build on Mac.

Reporter, please try the build from today.  Also, what addons do you have enabled?  If any, please disable them and try ftp again.
Flags: needinfo?(wtds.trabalho)

Comment 2

3 years ago
FTP is also working for me, nightly, Mac 10.9.5.
(Reporter)

Comment 3

3 years ago
Only E10S: The problem occurred only over authenticated FTP. For example: ftp://feitep.com.br/.
But working on non E10S mode. My version: 39.0a1 (2015-03-19)Windows 7 and Linux Mint
Flags: needinfo?(wtds.trabalho)
(Reporter)

Comment 4

3 years ago
** Please test first on E10S ** 
Only work if first login on non-E10S windows.

Comment 5

3 years ago
I'm able to reproduce with your STR in your dupe:

ftp://demo.wftpserver.com
    Username: demo-user
    Password: demo-user

Result: no authentication dialog box, blank page.
Blocks: 516752
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: ftp:// not working on E10S → Secured ftp:// with authentication dialog box not working on E10S

Updated

3 years ago
Duplicate of this bug: 1145412
Assignee: nobody → mrbkap
tracking-e10s: --- → m8+

Updated

3 years ago
Component: Untriaged → Networking: FTP
Product: Firefox → Core

Updated

3 years ago
Duplicate of this bug: 1170298
(Assignee)

Comment 8

3 years ago
Created attachment 8635023 [details] [diff] [review]
Patch v1

This turned out to be pretty straightforward. We had to expose nsIAuthPrompt2 through FTPChannelParent. Because we already pass the necessary information around, and the TabParent already implements nsIAuthPromptProvider, I had to change very little code.

My understanding is that Dragana isn't a peer of Necko yet, so I'm asking her for feedback. Bill, since this patch is mostly IPDL/DOM stuff anyway, would you mind reviewing? I'll verify with jduell before checkin to make sure he's cool with this, too.
Attachment #8635023 - Flags: review?(wmccloskey)
Attachment #8635023 - Flags: feedback?(dd.mozilla)
Comment on attachment 8635023 [details] [diff] [review]
Patch v1

Review of attachment 8635023 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/ftp/FTPChannelParent.cpp
@@ +471,5 @@
> +      return provider->GetAuthPrompt(nsIAuthPromptProvider::PROMPT_NORMAL,
> +                                     uuid,
> +                                     result);
> +    }
> +  }

Do we need to check if it is content process?
Attachment #8635023 - Flags: feedback?(dd.mozilla) → feedback+
(Assignee)

Comment 10

3 years ago
(In reply to Dragana Damjanovic [:dragana] from comment #9)
> ::: netwerk/protocol/ftp/FTPChannelParent.cpp
> Do we need to check if it is content process?

We'll only ever create FTPChannelParents (or nsFTPChannels) in the parent process, so we don't have to verify here that we're not in the content process.
Comment on attachment 8635023 [details] [diff] [review]
Patch v1

Review of attachment 8635023 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/ftp/FTPChannelParent.cpp
@@ +464,5 @@
> +      uuid.Equals(NS_GET_IID(nsISecureBrowserUI))) {
> +    if (mTabParent) {
> +      return mTabParent->QueryInterface(uuid, result);
> +    }
> +  } else if (uuid.Equals(NS_GET_IID(nsIAuthPrompt2))) {

Might as well include nsIAuthPrompt as well?

::: netwerk/protocol/ftp/FTPChannelParent.h
@@ +19,5 @@
>  class nsILoadContext;
>  
>  namespace mozilla {
> +
> +namespace dom{

Need space.

@@ +41,5 @@
>    NS_DECL_NSIPARENTCHANNEL
>    NS_DECL_NSIINTERFACEREQUESTOR
>    NS_DECL_NSICHANNELEVENTSINK
>  
> +  FTPChannelParent(const dom::PBrowserOrId& iframeEmbedding,

aIframeEmbedding (yuck).
Attachment #8635023 - Flags: review?(wmccloskey) → review+
(Assignee)

Comment 12

3 years ago
Created attachment 8636880 [details] [diff] [review]
Make FTP with auth prompts work in e10s. r=billm/dragana
(Assignee)

Comment 13

3 years ago
Comment on attachment 8636880 [details] [diff] [review]
Make FTP with auth prompts work in e10s. r=billm/dragana

https://treeherder.mozilla.org/#/jobs?repo=try&revision=2ba3015b532b

Jason, I understand that Dragana isn't a peer. Do you want to give this a once-over or are you OK with this landing with the reviews on this bug?
Attachment #8636880 - Flags: review?(jduell.mcbugs)
(Assignee)

Comment 14

3 years ago
Necko peer*
(Assignee)

Updated

3 years ago
Attachment #8635023 - Attachment is obsolete: true
Attachment #8636880 - Flags: review?(jduell.mcbugs) → review+
(Assignee)

Updated

3 years ago
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/dedc277a5abb
Status: NEW → RESOLVED
Last Resolved: 3 years ago
status-firefox42: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla42
You need to log in before you can comment on or make changes to this bug.