Closed Bug 1144643 Opened 5 years ago Closed 5 years ago

Gtk3 - support transparent and shaped widgets

Categories

(Core :: Widget: Gtk, defect)

All
Linux
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: stransky, Assigned: stransky)

References

Details

Attachments

(1 file)

Some elements in Gtk3 are supposed to be transparent or shaped. For instance overlay scrollbars and shaped tooltips.
Karl, what's the correct way to draw the semi-transparent and shaped widgets? Tweak nsNativeThemeGTK::GetWidgetTransparency() does not works, if it returns eTransparent the widgets still have some background...
Flags: needinfo?(karlt)
Please ignore that, sNativeThemeGTK::GetWidgetTransparency() works as expected.
Flags: needinfo?(karlt)
Attached patch patchSplinter Review
Uses transparent tooltips on Gtk3.
Attachment #8579353 - Flags: review?(karlt)
Attachment #8579353 - Flags: review?(karlt) → review+
Builds look okay.
Keywords: checkin-needed
Same as the other bug. Why did your Try runs include tooltool manifest changes?
Keywords: checkin-needed
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #6)
> Same as the other bug. Why did your Try runs include tooltool manifest
> changes?

This patch changes behaviour for only GTK3 builds, which are not in C-I.
GTK3 builds do run on elm periodically (or at least did run - I haven't checked), but with many test failures.  The tooltool changes from bug 1016641 provide an environment for a GTK3 build and so can be used to check that the build at least does not break.

Martin, if non-GTK2 parts of code are changed, it's probably usually helpful to also do a standard (GTK2) try build.  However, given the small change here, It's probably not worth it.
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/abf589d7f98d
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.