Closed Bug 1016641 (try-gtk3) Opened 8 years ago Closed 8 years ago

Make it possible to do GTK3 try builds

Categories

(Firefox Build System :: General, defect)

All
Linux
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla33

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(3 files, 6 obsolete files)

Considering all the limitations, I think the most workable short-term solution is to:
- Build GTK3 and its missing dependencies from Centos 6 so that it can be used under the source tree.
- Package it and upload to tooltool.
- Use it from tooltool on try.

The main problem is doing step 1.
Flags: needinfo?(catlee)
Sounds reasonable. Who's on the hook for this?
Flags: needinfo?(catlee)
I should have been more explicit in my need info :)  Chris, we need you to tell us who has the skills to do it.  We're assuming you'd know.
Flags: needinfo?(catlee)
Assignee: nobody → mh+mozilla
Blocks: gtk3
Flags: needinfo?(catlee)
Alias: try-gtk3
Depends on: 1027040
Depends on: 1027034
Depends on: 1027009
Depends on: 1027138
This is the first ever Mozilla-automation built Gtk+3 Firefox, with tests running (although as of writing, they are all pending ; at least the build went through):
  https://tbpl.mozilla.org/?tree=Try&rev=ee1398e6b7d9

It's m-c as of several hours ago + bug 1027034 + bug 1027040 + a backout of bug 984075 (as a workaround for bug 1027138) + the removal of --enable-warnings-as-errors from browser/config/mozconfigs/linux64/common-opt (as workaround for bug 1027009)
Note this is linux64 only.
Depends on: 1027000
Here is another attempt with the addition of the patch from bug 1027000:
   https://tbpl.mozilla.org/?tree=Try&rev=bc15590460f6

Someone will have to take a look at all those test oranges and file bugs (don't worry about the orange B, it's a linkage problem that's part of this bug)
Depends on: 1027440
Depends on: 1027448
Depends on: 1028137
With this landed, the only change that will be required to do try pushes for Gtk+3 is tooltool manifest changes.
Attachment #8443826 - Flags: review?(mshal)
Actually, better to use a less generic directory name. I'll change the tooltool archives accordingly.
Attachment #8443827 - Flags: review?(mshal)
Attachment #8443826 - Attachment is obsolete: true
Attachment #8443826 - Flags: review?(mshal)
Comment on attachment 8443827 [details] [diff] [review]
Add mozconfig magic for Gtk+3 builds

Looks good! Maybe just a quick comment before the 'if' that gtk3 comes from tooltool.
Attachment #8443827 - Flags: review?(mshal) → review+
Attached file Build script for gtk tooltool tarballs (obsolete) —
This is the script I used to build the tarballs currently in tooltool.
https://tbpl.mozilla.org/?tree=Try&rev=fbed7741fe42
(That try doesn't apply the patch from bug 1027497 so it crashes in gtest, and we're still in need for a proper fix for bug 1027138 instead of the backout of bug 984075.

Work in this particular bug is done, though, everything is setup so that one can do Gtk+3 try builds. I'll blog about this after bugs 1027497, 1027138 and 1027009 land.
Attachment #8442196 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/89fb025810ac
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 33
Depends on: 1031267
Blocks: 1034064
No longer blocks: 1034064
(In reply to Mike Hommey [:glandium] from comment #4)
> Note this is linux64 only.

Hey, is the final patch that landed in here also only supporting linux64 builds for GTK3 trys ?
I'm using your patch to drive runs (by the way, it works fine, thanks) and was wondering if I could do 32 bits now.
The last version of the patch does 32 bits too. You can also start from elm. http://glandium.org/blog/?p=3299
Attachment #8444888 - Attachment mime type: application/x-shellscript → text/plain
Attached file Build script for gtk tooltool tarballs (obsolete) —
We now need at-spi2-atk as well.
Attachment #8444888 - Attachment is obsolete: true
Attachment #8444892 - Attachment is obsolete: true
Attachment #8444892 - Attachment is obsolete: false
Attachment #8444888 - Attachment is obsolete: false
bug 1138845 made atk-bridge unnecessary.
Attachment #8571192 - Attachment is obsolete: true
Attachment #8571192 - Attachment mime type: application/x-shellscript → text/plain
Attachment #8571193 - Attachment is obsolete: true
Updated with the Gtk+ 3.4 package from a while ago
Attachment #8444892 - Attachment is obsolete: true
Attachment #8444888 - Attachment is obsolete: true
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 33 → mozilla33
You need to log in before you can comment on or make changes to this bug.