114469 - PK11_ImportDERPrivateKeyInfo should return a SECKEYPrivateKey*

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P1)

Description

[Jamie Nicolson]

If I call PK11_ImportDERPrivateKeyInfo, I should get back a pointer to the key I just created so I don't have to go hunting for it. This is especially true for JCA, where we will always want to get a pointer to a key after we import it.

Comment 1

[Jamie Nicolson]

Attachment: proposed patch

Add one private and two public functions to NSS.

PK11_ImportAndReturnPrivateKey(private)
PK11_ImportPrivateKeyInfoAndReturnKey(public)
PK11_ImportDERPrivateKeyInfoAndReturnKey(public)

These functions supplement three existing functions whose names are the same as
above without "AndReturnKey". The existing functions have been reimplemented to
call the new functions.

The new functions simply take an extra argument, a SECKEYPrivateKey**. If not
NULL, it will be pointed at the new private key that was imported. The old
functions got as far as recovering the PKCS #11 object ID of the new key, then
simply threw it away. The new functions go the extra step of wrapping the
object ID and slot in a SECKEYPrivateKey*.

Comment 2

[Jamie Nicolson]

Attachment: proposed patch

Add one private and two public functions to NSS.

PK11_ImportAndReturnPrivateKey(private)
PK11_ImportPrivateKeyInfoAndReturnKey(public)
PK11_ImportDERPrivateKeyInfoAndReturnKey(public)

These functions supplement three existing functions whose names are the same as
above without "AndReturnKey". The existing functions have been reimplemented to
call the new functions.

The new functions simply take an extra argument, a SECKEYPrivateKey**. If not
NULL, it will be pointed at the new private key that was imported. The old
functions got as far as recovering the PKCS #11 object ID of the new key, then
simply threw it away. The new functions go the extra step of wrapping the
object ID and slot in a SECKEYPrivateKey*.

Comment 3

[Robert Relyea]

looks OK Jamie, though I would have liked to see the public function return the
key as a parameter rather than return it as a parameter.

The implementation is fine. (it's okay for the internal function to take the
parameter so we don't allocate a new key when we don't need it).

bob

Comment 4

[Jamie Nicolson]

Committed to trunk.

/cvsroot/mozilla/security/nss/lib/nss/nss.def,v  <--  nss.def
new revision: 1.44; previous revision: 1.43
done
Checking in pk11wrap/pk11func.h;
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11func.h,v  <--  pk11func.h
new revision: 1.21; previous revision: 1.20
done
Checking in pk11wrap/pk11pk12.c;
/cvsroot/mozilla/security/nss/lib/pk11wrap/pk11pk12.c,v  <--  pk11pk12.c
new revision: 1.3; previous revision: 1.2