1144711 - return 404 for version update requests on unlisted addons

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Mathieu Agopian [:magopian]]

Requests to the "version update" service should return a 404 for unlisted addons.

Comment 1

[Mathieu Agopian [:magopian]]

PR: https://github.com/mozilla/olympia/pull/491

Comment 2

[Mathieu Agopian [:magopian]]

Fixed in https://github.com/mozilla/olympia/commit/81f63593e4dc378bd8e5d8cfead62beef4c61204

Comment 3

[Madalin Cotetiu]

Not sure where we should see that 404. Mathieu, can you please give us some more detailed steps?

Comment 4

[Mathieu Agopian [:magopian]]

I don't know if you can test this (the update checks) on -dev or stage?

I think there's an about:config setting to configure Firefox to go check the latest versions of an addon on a given url.

The STR (for -dev):
1/ upload an unlisted add-on on -dev
2/ install it manually (there's no public pages, but you should be able to download it manually from the devhub pages)
3/ upload a newer version of this add-on on -dev (don't install it manually)
4/ have firefox check for updates on -dev, and verify that it doesn't find this new version

If you do those exact same steps with a listed addon, Firefox should automatically detect the new version and install it.

Comment 5

[Madalin Cotetiu]

I have found the setting it is called extensions.update.url. Its original value is: https://versioncheck.addons.mozilla.org/update/VersionCheck.php?reqVersion=%REQ_VERSION%&id=%ITEM_ID%&version=%ITEM_VERSION%&maxAppVersion=%ITEM_MAXAPPVERSION%&status=%ITEM_STATUS%&appID=%APP_ID%&appVersion=%APP_VERSION%&appOS=%APP_OS%&appABI=%APP_ABI%&locale=%APP_LOCALE%&currentAppVersion=%CURRENT_APP_VERSION%&updateType=%UPDATE_TYPE%&compatMode=%COMPATIBILITY_MODE%

I have modified that to 
https://versioncheck.addons-dev.allizom.org/update/VersionCheck.php?reqVersion=%REQ_VERSION%&id=%ITEM_ID%&version=%ITEM_VERSION%&maxAppVersion=%ITEM_MAXAPPVERSION%&status=%ITEM_STATUS%&appID=%APP_ID%&appVersion=%APP_VERSION%&appOS=%APP_OS%&appABI=%APP_ABI%&locale=%APP_LOCALE%&currentAppVersion=%CURRENT_APP_VERSION%&updateType=%UPDATE_TYPE%&compatMode=%COMPATIBILITY_MODE%

But when I try to force an update to an add-on it doesn't work. I have tried with both an listed and an unlisted add-on with no success. I think that value should be something else, but I'm not sure how it should look.

Comment 6

[Mathieu Agopian [:magopian]]

I think the correct url is:

https://versioncheck-dev.allizom.org/update/VersionCheck.php?reqVersion=%25REQ_VERSION%25&id=%25ITEM_ID%25&version=%25ITEM_VERSION%25&maxAppVersion=%25ITEM_MAXAPPVERSION%25&status=%25ITEM_STATUS%25&appID=%25APP_ID%25&appVersion=%25APP_VERSION%25&appOS=%25APP_OS%25&appABI=%25APP_ABI%25&locale=%25APP_LOCALE%25&currentAppVersion=%25CURRENT_APP_VERSION%25&updateType=%25UPDATE_TYPE%25&compatMode=%25COMPATIBILITY_MODE%25

Comment 7

[Mathieu Agopian [:magopian]]

Sorry, got some %25 everywhere in this url, try this:

https://versioncheck-dev.allizom.org/update/VersionCheck.php?reqVersion=%REQ_VERSION%&id=%ITEM_ID%&version=%ITEM_VERSION%&maxAppVersion=%ITEM_MAXAPPVERSION%&status=%ITEM_STATUS%&appID=%APP_ID%&appVersion=%APP_VERSION%&appOS=%APP_OS%&appABI=%APP_ABI%&locale=%APP_LOCALE%&currentAppVersion=%CURRENT_APP_VERSION%&updateType=%UPDATE_TYPE%&compatMode=%COMPATIBILITY_MODE%

Comment 8

[Madalin Cotetiu]

That works like a charm :)
I have tried with an normal public add-on and update is successful. For an unlisted add-on no updates are found.
Screencast: http://screencast.com/t/uUnqRD93

Closing bug.