Closed Bug 1144774 Opened 7 years ago Closed 6 years ago
Add to reading list button is blurry
Applying shape-rendering: crispEdges to the "plus" icon mask should fix things.
Also removed xml:space, since it's fairly useless if there's no text in the SVG.
Attachment #8579512 - Flags: review?(gijskruitbosch+bugs)
Attachment #8579512 - Flags: review?(gijskruitbosch+bugs) → review?(jaws)
Comment on attachment 8579512 [details] [diff] [review] Patch Review of attachment 8579512 [details] [diff] [review]: ----------------------------------------------------------------- crispEdges is causing it the rectangles to get off-center on my local build, http://screencast.com/t/tEd0t1WuxjDE Have we looked at using the + character (if possible)?
Attachment #8579512 - Flags: review?(jaws) → feedback-
This is because of the half pixels specified in the SVG - it needs to be pixel aligned by increasing the circle radius or by using either thinner or thicker lines (I didn't get a chance to follow up on that). I didn't look into using a "+" or "-" character - IIRC, we've had trouble doing that in the past with small things, because we can't reliably get it centered and looking right (different OSes drawing differently, different fonts imposed), and any deviation is really obvious at that small scale.
(Hard for me to judge with the fuzzy upscaling on my Retina display, but let's tag this as P3. Could be a P4/P5 if it's more subtle that I'm thinking.)
Priority: -- → P3
(In reply to Justin Dolske [:Dolske] from comment #4) > (Hard for me to judge with the fuzzy upscaling on my Retina display The icon is an SVG file, so I don't expect any fuzzy upscaling for retina mac displays.
Screenshot with the patch: http://i.imgur.com/njxNwbq.png Screenshot without the patch: http://i.imgur.com/mBT1isa.png
6 years ago
Attachment #8589638 - Flags: ui-review?(mmaslaney) → ui-review+
Attachment #8589638 - Flags: review?(jaws) → review+
Thanks for picking this up Florian !
Assignee: ntim.bugs → florian
Hi Florian, can you provide a point value.
Iteration: --- → 40.1 - 13 Apr
Points: --- → 2
Comment on attachment 8589638 [details] [diff] [review] Patch Approval Request Comment [Feature/regressing bug #]: ReadingList [User impact if declined]: Blurry icon in the URL bar [Describe test coverage new/current, TreeHerder]: QA will verify. [Risks and why]: Low, only tweaking an SVG file. [String/UUID change made/needed]: none.
Comment on attachment 8589638 [details] [diff] [review] Patch Should be 38 beta 3 (or 4)
Verified fixed on 38.0b3-build1 (20150409144858), using Ubuntu 14.04 (x64), Windows 8.1 (x64) and Mac OS X 10.9.5.
Removing qe-verify flag, as verification on 38 Beta should suffice here.
You need to log in before you can comment on or make changes to this bug.