1144823 - reading list sidebar should be sorted by most recently added

Status: VERIFIED FIXED

(Firefox Graveyard :: Reading List, defect)

Description

[Bryan Clark (DevTools PM) [:clarkbw]]

currently the most recently added items are appending to the list, we want those items pre-pended and that sort order to be constant.

Comment 1

[Florian Quèze [:florian]]

Attachment: Patch

Comment 2

[Marco Mucci [:MarcoM]]

Hi Florian, can you provide a point value.

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8580426 [details] [diff] [review]
Patch

Review of attachment 8580426 [details] [diff] [review]:
-----------------------------------------------------------------

As we discussed, let's just get ReadingList.jsm to populate the added-on date and use this as the sort key.

Comment 4

[Florian Quèze [:florian]]

Attachment: Patch v2

As discussed, this populates the addedOn field of the database, and also sorts the bookmarks popup.

Comment 5

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8580826 [details] [diff] [review]
Patch v2

Review of attachment 8580826 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/readinglist/sidebar.js
@@ +90,5 @@
>      log.trace(`onItemAdded: ${item}`);
>  
>      let itemNode = document.importNode(this.itemTemplate.content, true).firstElementChild;
>      this.updateItem(item, itemNode);
> +    if (append)

Please add a comment indicating this is a temp hack and will need to be re-worked when items come from the sync engine.

Comment 6

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/b11aaab4a248

Comment 7

[Drew Willcoxon :adw]

This broke test_ReadingList.js, but I landed a fix in 6305033b955e in bug 1131416.

Comment 8

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/b11aaab4a248

Comment 9

[Andrei Vaida [:avaida]]

Verified fixed on Nightly 39.0a1 (2015-03-23), using Ubuntu 14.04 (x64), Mac OS X 10.9.5 and Windows 7 (x64).

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2dbde197a04e

Comment 11

[Andrei Vaida [:avaida]]

Verified fixed on Aurora 38.0a2 (2015-03-29) as well, using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.

Comment 12

[Justin Dolske [:Dolske]]

(In reply to Mark Hammond [:markh] from comment #5)

> Please add a comment indicating this is a temp hack and will need to be
> re-worked when items come from the sync engine.

Filed bug 1149823 for this.