1144889 - WebGL 2 unavailable. Requires feature sRGB

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect)

Description

[(not reading bugmail) Nick Desaulniers [:\n]]

When I run the following statement in my dev console with webgl.enable-prototype-webgl2 flipped:

document.createElement('canvas').getContext('experimental-webgl2')


I see:

null
Error: WebGL: Disallowing antialiased backbuffers due to blacklisting.
Error: WebGL: WebGL 2 unavailable. Requires feature sRGB.
Error: WebGL: WebGL creation failed.

This is on OSX 10.8.5 w/ Intel HD 4000 + NVIDIA 650M

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: 0001-Fancy-sRGB-GLFeature-detection-should-suppliment-not.patch

Comment 2

[u480271]

Comment on attachment 8579665 [details] [diff] [review]
0001-Fancy-sRGB-GLFeature-detection-should-suppliment-not.patch

Review of attachment 8579665 [details] [diff] [review]:
-----------------------------------------------------------------

As discussed on IRC, I implemented this also: https://github.com/djg/gecko-dev/commit/8e585b2822137c88a00039b57630abbbf4d0dc60

I'd like to see the two patches merged and also the removal of sRGB feature, as you suggested.

::: gfx/gl/GLContext.cpp
@@ +1692,2 @@
>          if (nsCocoaFeatures::OSXVersionMajor() == 10 &&
> +            nsCocoaFeatures::OSXVersionMinor() == 9 &&

This change undoes a feature I landed. r-

Comment 3

[Kelsey Gilbert [:jgilbert]]

Attachment: 0001-Do-proper-sRGB-detection.patch

Comment 4

[u480271]

Comment on attachment 8580270 [details] [diff] [review]
0001-Do-proper-sRGB-detection.patch

Review of attachment 8580270 [details] [diff] [review]:
-----------------------------------------------------------------

r- because this patch reverts fix for Bug 1124996. Revert that and r+

::: gfx/gl/GLContext.cpp
@@ +1693,2 @@
>          if (nsCocoaFeatures::OSXVersionMajor() == 10 &&
> +            nsCocoaFeatures::OSXVersionMinor() == 9 &&

This still needs to be reverted.

Comment 5

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8580270 [details] [diff] [review]
0001-Do-proper-sRGB-detection.patch

Review of attachment 8580270 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContext.cpp
@@ +1693,2 @@
>          if (nsCocoaFeatures::OSXVersionMajor() == 10 &&
> +            nsCocoaFeatures::OSXVersionMinor() == 9 &&

This is git misbehaving.

Comment 6

[Kelsey Gilbert [:jgilbert]]

Attachment: 0001-Do-proper-sRGB-detection.patch

Comment 7

[u480271]

> This is git misbehaving.

Shakes fist at git.

Comment 8

[Kelsey Gilbert [:jgilbert]]

Attachment: 0002-Fix-some-formatting.patch

Comment 9

[Kelsey Gilbert [:jgilbert]]

Attachment: 0003-Re-blacklist-OSX-10.6-for-sRGB_framebuffer.patch

Comment 10

[Kelsey Gilbert [:jgilbert]]

 https://hg.mozilla.org/integration/mozilla-inbound/rev/6e7d781ad81e

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6e7d781ad81e