1145192 - GeckoProfile spamming Android log with: Fetching profile: '', 'null'

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Data Providers, defect)

Description

[Matt Brubeck (:mbrubeck)]

Aurora 38 (running on Nexus 4, Android 5.0) is writing this line the logs several times per second:

V/GeckoProfile(11747): Fetching profile: '', 'null'

Possibly related to bug 1077590, which added this log line.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Let's remove or hide this output based on the logging state.

Comment 2

[Dylan Roeh (:droeh) (he/him)]

Attachment: Proposed patch

Proposed patch; this just skips the logging when profileName is an empty string and profileDir is null.

Comment 3

[Dylan Roeh (:droeh) (he/him)]

Attachment: Proposed patch (updated)

Updates previously proposed patch, moving logging statement to an else clause a few lines down.

Comment 4

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8628484 [details] [diff] [review]
Proposed patch (updated)

Review of attachment 8628484 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoProfile.java
@@ +253,5 @@
>                  // We're unable to do anything sane here.
>                  throw new RuntimeException(e);
>              }
>          }
> +        else {

Put the else on the same line as the closing brace above, looks good otherwise.

Comment 5

[Dylan Roeh (:droeh) (he/him)]

Attachment: Proposed patch (updated)

Stylistic fix

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8628489 [details] [diff] [review]
Proposed patch (updated)

Review of attachment 8628489 [details] [diff] [review]:
-----------------------------------------------------------------

Oops. You need to fix the commit message. Something like:

Bug 1145192 - Don't spam the logs when retrieving the profile on Android r=snorp

The message should say what the patch does, and the r=snorp means it was reviewed (and approved) by me.

Comment 7

[Dylan Roeh (:droeh) (he/him)]

Attachment: Proposed patch (updated)

Fixed commit message

Comment 8

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/bd08740485d0

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bd08740485d0