1145448 - When fullscreen window lose focus, a fake title bar is painted

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

Attachment: screenshot

Steps to reproduce:
1. Make something in fullscreen (DOM fullscreen, not fullscreen mode)
2. Switch to some other window
3. Go back to the fullscreen window

There will be a strange title bar at the top of the fullscreen. However, this title bar is actually transparent to any pointer event. I guess it is just something mispainted.

This doesn't happen on the current release, but reproducible on aurora and nightly.

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Attachment: patch

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Although I cannot reproduce bug 1064787, this patch probably could also fix that bug.

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 8590064 [details] [diff] [review]
patch

confirmed locally this fixes the problem.

Comment 5

[Jim Mathies [:jimm]]

Lets nominate this for aurora and beta uplift once it lands and sticks.

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a18674a6e42

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8590064 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]: unknown, but seems to be a significant regression since current beta
[User impact if declined]: will see unwanted fake title bar on the top, which is hard to remove if the page doesn't change anything on that area
[Describe test coverage new/current, TreeHerder]: no test for this particular problem
[Risks and why]: doesn't seem to have risk since it just stop system from painting its ui on fullscreen mode
[String/UUID change made/needed]: n/a

Comment 8

[Jim Mathies [:jimm]]

Thanks!

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3a18674a6e42

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8590064 [details] [diff] [review]
patch

Approving for uplift to aurora. Looks like a recent regression; treeherder looks ok with this change.

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/8c4d11ea4b58

Comment 12

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8590064 [details] [diff] [review]
patch

We probably want that in beta too.

Should be in 38 beta 5.

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/a27fb9b83867

Comment 14

[[SV Manager] Florin Mezei, QA (:FlorinMezei)]

Reproduced the original issue on Windows 7 x64, using Firefox 38 Beta 4 and Firefox 39 from April 8th.

The issue no longer reproduces on:
- Firefox 38 Beta 5 - BuildID=20150416143048
- latest Firefox 39 Aurora - BuildID=20150416004008
- latest Firefox 40 Nightly - BuildID=20150416143048