Closed Bug 1145553 Opened 5 years ago Closed 5 years ago

Remove remaining usage of enablePrivilege in crashtests

Categories

(Testing :: Reftest, defect)

x86
macOS
defect
Not set

Tracking

(firefox39 fixed)

RESOLVED FIXED
mozilla39
Tracking Status
firefox39 --- fixed

People

(Reporter: martijn.martijn, Assigned: martijn.martijn)

References

(Blocks 1 open bug)

Details

Attachments

(1 file, 1 obsolete file)

I removed all enablePrivilege usage in bug 917061, but some usage has crept back:
> gfx/tests/crashtests/358732-iframe.html
> gfx/tests/crashtests/358732-3.html
> layout/generic/crashtests/370174-3.html
> layout/generic/crashtests/370174-4.html

We should remove usage there, it should be possible to use SpecialPowers.
Attached patch 1145553.diffSplinter Review
Attachment #8580676 - Flags: review?(jmaher)
Assignee: nobody → martijn.martijn
Comment on attachment 8580676 [details] [diff] [review]
1145553.diff

Review of attachment 8580676 [details] [diff] [review]:
-----------------------------------------------------------------

nice cleanup!
Attachment #8580676 - Flags: review?(jmaher) → review+
All green.
Keywords: checkin-needed
Parsing...Patch id=8580676 desc="1145553.diff" diff data were discarded:
UnicodeDecodeError: 'utf8' codec can't decode byte 0x96 in position 537: invalid start byte
Keywords: checkin-needed
I don't understand, the patch applies just fine, locally. What do I need to change?
(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #5)
> Parsing...Patch id=8580676 desc="1145553.diff" diff data were discarded:
> UnicodeDecodeError: 'utf8' codec can't decode byte 0x96 in position 537:
> invalid start byte

Joel, do you happen to know what I need to do to get a patch that doesn't produce this error during import?
The patch applies cleanly on my machine.
Flags: needinfo?(jmaher)
I just downloaded the patch attached to this bug and did a 'hg qimport <patchname>; hg qpush' and it worked just fine.

I am on Linux, quite possibly there is an OS issue?
Flags: needinfo?(jmaher)
Attached patch 1145553.diff (obsolete) — Splinter Review
So it happens because of the weird '-' in 'Bug 358732 - Crash in _moz_cairo_win32_scaled_font_select_font, part 2'.
I'll just replace it with the normal '-'. Not sure if this patch would be picked up either, though.
Attachment #8583748 - Flags: review?(jmaher)
Comment on attachment 8583748 [details] [diff] [review]
1145553.diff

Review of attachment 8583748 [details] [diff] [review]:
-----------------------------------------------------------------

so many details :)
Attachment #8583748 - Flags: review?(jmaher) → review+
Attachment #8580676 - Attachment is obsolete: true
Keywords: checkin-needed
applying 1145553
patching file gfx/tests/crashtests/358732-3.html
Hunk #1 FAILED at 0
1 out of 1 hunks FAILED -- saving rejects to file gfx/tests/crashtests/358732-3.html.rej
patching file gfx/tests/crashtests/358732-iframe.html
Hunk #1 FAILED at 6
1 out of 1 hunks FAILED -- saving rejects to file gfx/tests/crashtests/358732-iframe.html.rej
patching file layout/generic/crashtests/370174-4.html
Hunk #1 FAILED at 6
1 out of 1 hunks FAILED -- saving rejects to file layout/generic/crashtests/370174-4.html.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 1145553

That was with attachment 8583748 [details] [diff] [review] after manually importing it (still having qimportbz issues with it).
Keywords: checkin-needed
Attachment #8583748 - Attachment is obsolete: true
Attachment #8580676 - Attachment is obsolete: false
I'm out of ideas. It seems some kind of encoding issue, but I don't know how to solve it.
https://hg.mozilla.org/mozilla-central/rev/7c2073c5cc7e
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
You need to log in before you can comment on or make changes to this bug.