1145553 - Remove remaining usage of enablePrivilege in crashtests

Status: RESOLVED FIXED

(Testing :: Reftest, defect)

Description

[Martijn Wargers (dead)]

I removed all enablePrivilege usage in bug 917061, but some usage has crept back:
> gfx/tests/crashtests/358732-iframe.html
> gfx/tests/crashtests/358732-3.html
> layout/generic/crashtests/370174-3.html
> layout/generic/crashtests/370174-4.html

We should remove usage there, it should be possible to use SpecialPowers.

Comment 1

[Martijn Wargers (dead)]

Attachment: 1145553.diff

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8580676 [details] [diff] [review]
1145553.diff

Review of attachment 8580676 [details] [diff] [review]:
-----------------------------------------------------------------

nice cleanup!

Comment 3

[Martijn Wargers (dead)]

Pushed to try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=f2163d53daba

Comment 4

[Martijn Wargers (dead)]

All green.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Parsing...Patch id=8580676 desc="1145553.diff" diff data were discarded:
UnicodeDecodeError: 'utf8' codec can't decode byte 0x96 in position 537: invalid start byte

Comment 6

[Martijn Wargers (dead)]

I don't understand, the patch applies just fine, locally. What do I need to change?

Comment 7

[Martijn Wargers (dead)]

(In reply to Ryan VanderMeulen [:RyanVM UTC-4] from comment #5)
> Parsing...Patch id=8580676 desc="1145553.diff" diff data were discarded:
> UnicodeDecodeError: 'utf8' codec can't decode byte 0x96 in position 537:
> invalid start byte

Joel, do you happen to know what I need to do to get a patch that doesn't produce this error during import?
The patch applies cleanly on my machine.

Comment 8

[Joel Maher ( :jmaher ) (UTC -8)]

I just downloaded the patch attached to this bug and did a 'hg qimport <patchname>; hg qpush' and it worked just fine.

I am on Linux, quite possibly there is an OS issue?

Comment 9

[Martijn Wargers (dead)]

Attachment: 1145553.diff

So it happens because of the weird '-' in 'Bug 358732 - Crash in _moz_cairo_win32_scaled_font_select_font, part 2'.
I'll just replace it with the normal '-'. Not sure if this patch would be picked up either, though.

Comment 10

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8583748 [details] [diff] [review]
1145553.diff

Review of attachment 8583748 [details] [diff] [review]:
-----------------------------------------------------------------

so many details :)

Comment 11

[Ryan VanderMeulen [:RyanVM]]

applying 1145553
patching file gfx/tests/crashtests/358732-3.html
Hunk #1 FAILED at 0
1 out of 1 hunks FAILED -- saving rejects to file gfx/tests/crashtests/358732-3.html.rej
patching file gfx/tests/crashtests/358732-iframe.html
Hunk #1 FAILED at 6
1 out of 1 hunks FAILED -- saving rejects to file gfx/tests/crashtests/358732-iframe.html.rej
patching file layout/generic/crashtests/370174-4.html
Hunk #1 FAILED at 6
1 out of 1 hunks FAILED -- saving rejects to file layout/generic/crashtests/370174-4.html.rej
patch failed, unable to continue (try -v)
patch failed, rejects left in working dir
errors during apply, please fix and refresh 1145553

That was with attachment 8583748 [details] [diff] [review] after manually importing it (still having qimportbz issues with it).

Comment 12

[Martijn Wargers (dead)]

I'm out of ideas. It seems some kind of encoding issue, but I don't know how to solve it.

Comment 13

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7c2073c5cc7e

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7c2073c5cc7e