11456 - xul keybindings: need to handle special keys (pgup,end,F1,etc.)

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Kathleen :Brade]

Editor requirement is to be able to map the entire keyboard with keybindings.
This includes keys: PageUp, PageDown, Home, End, arrow keys, tab key, delete/
backspace, forward delete, and function keys (F1-F15).

Comment 1

[saari (gone)]

waiting on verifications from brade and akkana

Comment 2

[saari (gone)]

Full keyboard support is checked in, but there are other key event issues that may make testing this difficult.

Marking fixed.

Comment 3

[Kathleen :Brade]

I wasn't able to get any JS errors for the current mappings (added in
editorOverlay.xul) which point to non-existent JS functions.  I assume they
aren't working but haven't put any breakpoints in the code.  Perhaps my syntax is
incorrect?

Comment 4

[saari (gone)]

Hold on for a sec, the overlay for editor looks horked, and I've got more changes

I did last night... But I have to figure out what is horked with the overlay to

start with.

Comment 5

[Paul MacQuiddy]

Sorry for spam, re-assigning phillip's QA contact XPToolkit/XPWidget bugs to
claudius due to restructure

Comment 6

[leger]

Putting on [PDT]+ radar.

Comment 7

[Claudius Gayle]

sorry for sitting on this - passing on to Mr. Keyboard Navigation himself, cpratt.

Comment 8

[Claudius Gayle]

oops forgot to actually hand it off.

Comment 9

[cpratt]

Not sure how to verify this... it seems that these keys are present if not
always working correctly based on this month's builds on Linux and NT at least.
So, I'm going to just mark this as verified... brade et al, if this is Bad,
please reopen ASAP. thanks!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df1f91598fc5
[fenix] For https://github.com/mozilla-mobile/fenix/issues/11456: AddonDetailsFragment should use ConstraintLayout, not RelativeLayout