Closed
Bug 1145631
Opened 9 years ago
Closed 9 years ago
Stop using MOZ_OVERRIDE and MOZ_FINAL
Categories
(Core :: MFBT, defect)
Tracking
()
RESOLVED
FIXED
mozilla39
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
References
(Depends on 1 open bug)
Details
Attachments
(6 files)
6.81 MB,
patch
|
froydnj
:
review+
Sylvestre
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
3.51 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
3.01 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
979 bytes,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
1.16 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
8.49 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
We can now use the override and final keywords.
Assignee | ||
Comment 1•9 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4776b6bbfede
Assignee | ||
Comment 2•9 years ago
|
||
This patch was automatically generated using the following script: function convert() { echo "Converting $1 to $2..." find . \ ! -wholename "*/.git*" \ ! -wholename "obj-ff-dbg*" \ -type f \ \( -iname "*.cpp" \ -o -iname "*.h" \ -o -iname "*.c" \ -o -iname "*.cc" \ -o -iname "*.idl" \ -o -iname "*.ipdl" \ -o -iname "*.ipdlh" \ -o -iname "*.mm" \) | \ xargs -n 1 sed -i -e "s/\b$1\b/$2/g" } convert MOZ_OVERRIDE override convert MOZ_FINAL final
Attachment #8580812 -
Flags: review?(nfroyd)
Assignee | ||
Comment 3•9 years ago
|
||
Attachment #8580813 -
Flags: review?(nfroyd)
Assignee | ||
Comment 4•9 years ago
|
||
Attachment #8580814 -
Flags: review?(nfroyd)
Assignee | ||
Comment 5•9 years ago
|
||
Attachment #8580816 -
Flags: review?(nfroyd)
Assignee | ||
Comment 6•9 years ago
|
||
Attachment #8580817 -
Flags: review?(nfroyd)
Assignee | ||
Comment 7•9 years ago
|
||
Attachment #8580818 -
Flags: review?(nfroyd)
Updated•9 years ago
|
Attachment #8580812 -
Flags: review?(nfroyd) → review+
Updated•9 years ago
|
Attachment #8580813 -
Flags: review?(nfroyd) → review+
Updated•9 years ago
|
Attachment #8580814 -
Flags: review?(nfroyd) → review+
Updated•9 years ago
|
Attachment #8580816 -
Flags: review?(nfroyd) → review+
Updated•9 years ago
|
Attachment #8580817 -
Flags: review?(nfroyd) → review+
Updated•9 years ago
|
Attachment #8580818 -
Flags: review?(nfroyd) → review+
Assignee | ||
Comment 8•9 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/ac4464790ec4 https://hg.mozilla.org/integration/mozilla-inbound/rev/08912c0b2b5d https://hg.mozilla.org/integration/mozilla-inbound/rev/745287406d9e https://hg.mozilla.org/integration/mozilla-inbound/rev/bd5245b8886d https://hg.mozilla.org/integration/mozilla-inbound/rev/79371ae69603 https://hg.mozilla.org/integration/mozilla-inbound/rev/7c491d4a0e06
Comment 9•9 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/ac4464790ec4 https://hg.mozilla.org/mozilla-central/rev/08912c0b2b5d https://hg.mozilla.org/mozilla-central/rev/745287406d9e https://hg.mozilla.org/mozilla-central/rev/bd5245b8886d https://hg.mozilla.org/mozilla-central/rev/79371ae69603 https://hg.mozilla.org/mozilla-central/rev/7c491d4a0e06
Status: NEW → RESOLVED
Closed: 9 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla39
Comment 10•9 years ago
|
||
Can we please do this on Aurora as well? The gcc support situation is the same and it's already annoyance on uplifts (and will continue to do so throughout the ESR cycle otherwise).
Flags: needinfo?(ehsan)
Assignee | ||
Comment 12•9 years ago
|
||
Comment on attachment 8580812 [details] [diff] [review] Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree This change doesn't affect our binaries, it only removes a C++ macro which has been obsoleted by our compiler upgrades, and is mostly generated through a script. Uplifting this will make future uplifts for other bugs easier (see comment 10.)
Attachment #8580812 -
Flags: approval-mozilla-aurora?
Comment 13•9 years ago
|
||
Comment on attachment 8580812 [details] [diff] [review] Part 1: Replace MOZ_OVERRIDE and MOZ_FINAL with override and final in the tree I guess this is going to make the life of some people harder (they will just have to revert this change) but as 38 is an esr, we want the uplifts to be as easy as possible.
Attachment #8580812 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 14•9 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/a20c7910a82f https://hg.mozilla.org/releases/mozilla-aurora/rev/15d231833bde https://hg.mozilla.org/releases/mozilla-aurora/rev/2f1e4ecb55d8 https://hg.mozilla.org/releases/mozilla-aurora/rev/b81a700d1cf9 https://hg.mozilla.org/releases/mozilla-aurora/rev/5f2da0467e96 https://hg.mozilla.org/releases/mozilla-aurora/rev/0f67ff87b8ea
status-firefox38:
--- → fixed
Comment 15•9 years ago
|
||
Anyone of you mind updating https://developer.mozilla.org/en-US/docs/Mozilla/C++_Portability_Guide with the new rationale and recommendations?
Comment 16•9 years ago
|
||
(In reply to Gian-Carlo Pascutto [:gcp] from comment #15) > Anyone of you mind updating > https://developer.mozilla.org/en-US/docs/Mozilla/C++_Portability_Guide > with the new rationale and recommendations? Done.
You need to log in
before you can comment on or make changes to this bug.
Description
•