1145892 - Add null check to clientrecords in ShareDialog

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Overlays, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Missed a spot.

Comment 1

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: bz://1145892/mcomella

/r/5817 - Bug 1145892 - Add null check in ShareDialog.handleSendTabUIEvent. r=rnewman

Pull down this commit:

hg pull review -r 3e93e41b9e484087f456b785f1947e5e7697e05b

Comment 2

[Richard Newman [:rnewman]]

Comment on attachment 8580979 [details]
MozReview Request: bz://1145892/mcomella

https://reviewboard.mozilla.org/r/5815/#review4789

Ship It!

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/integration/fx-team/rev/ad46c4efdc6b

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/ad46c4efdc6b

Comment 5

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Comment on attachment 8580979 [details]
MozReview Request: bz://1145892/mcomella

This should be uplifted with bug 1122302.

Approval Request Comment
[Feature/regressing bug #]: bug 1122302
[User impact if declined]:
  Users who get null a clientrecord (I'm not sure the STR - maybe never having signed up for sync befor) will crash

[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: 
  Low - null check.

[String/UUID change made/needed]: None

Comment 6

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7e03a2d21565

Comment 9

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Attachment: MozReview Request: Bug 1145892 - Add null check in ShareDialog.handleSendTabUIEvent. r=rnewman