Closed
Bug 1145892
Opened 6 years ago
Closed 6 years ago
Add null check to clientrecords in ShareDialog
Categories
(Firefox for Android Graveyard :: Overlays, defect)
Tracking
(firefox38 fixed, firefox39 fixed)
RESOLVED
FIXED
Firefox 39
People
(Reporter: mcomella, Assigned: mcomella)
References
Details
Attachments
(1 file, 1 obsolete file)
Missed a spot.
Assignee | ||
Comment 1•6 years ago
|
||
/r/5817 - Bug 1145892 - Add null check in ShareDialog.handleSendTabUIEvent. r=rnewman Pull down this commit: hg pull review -r 3e93e41b9e484087f456b785f1947e5e7697e05b
Attachment #8580979 -
Flags: review?(rnewman)
Updated•6 years ago
|
Status: NEW → ASSIGNED
Component: General → Overlays
Updated•6 years ago
|
Attachment #8580979 -
Flags: review?(rnewman) → review+
Comment 2•6 years ago
|
||
Comment on attachment 8580979 [details] MozReview Request: bz://1145892/mcomella https://reviewboard.mozilla.org/r/5815/#review4789 Ship It!
Assignee | ||
Comment 3•6 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/ad46c4efdc6b
https://hg.mozilla.org/mozilla-central/rev/ad46c4efdc6b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox39:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Assignee | ||
Comment 5•6 years ago
|
||
Comment on attachment 8580979 [details] MozReview Request: bz://1145892/mcomella This should be uplifted with bug 1122302. Approval Request Comment [Feature/regressing bug #]: bug 1122302 [User impact if declined]: Users who get null a clientrecord (I'm not sure the STR - maybe never having signed up for sync befor) will crash [Describe test coverage new/current, TreeHerder]: None [Risks and why]: Low - null check. [String/UUID change made/needed]: None
Attachment #8580979 -
Flags: approval-mozilla-aurora?
Updated•6 years ago
|
Attachment #8580979 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Assignee | ||
Comment 6•6 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/7e03a2d21565
Assignee | ||
Updated•6 years ago
|
status-firefox38:
--- → fixed
Assignee | ||
Comment 8•6 years ago
|
||
Attachment #8580979 -
Attachment is obsolete: true
Attachment #8619834 -
Flags: review+
Assignee | ||
Comment 9•6 years ago
|
||
Updated•3 months ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•