Closed Bug 1145892 Opened 6 years ago Closed 6 years ago

Add null check to clientrecords in ShareDialog

Categories

(Firefox for Android Graveyard :: Overlays, defect)

Product:
Firefox for Android Graveyard
Component:
Overlays
Platform:
All
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox38 fixed, firefox39 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 39
Tracking Flags:
Tracking Status
firefox38 --- fixed
firefox39 --- fixed

People

(Reporter: mcomella, Assigned: mcomella)

References

Details

Attachments

(1 file, 1 obsolete file)

MozReview Request: Bug 1145892 - Add null check in ShareDialog.handleSendTabUIEvent. r=rnewman
39 bytes, text/x-review-board-request
rnewman
: review+
Details 
/r/5817 - Bug 1145892 - Add null check in ShareDialog.handleSendTabUIEvent. r=rnewman

Pull down this commit:

hg pull review -r 3e93e41b9e484087f456b785f1947e5e7697e05b
Attachment #8580979 - Flags: review?(rnewman)
Status: NEW → ASSIGNED
Component: General → Overlays
Attachment #8580979 - Flags: review?(rnewman) → review+
Comment on attachment 8580979 [details]
MozReview Request: bz://1145892/mcomella

https://reviewboard.mozilla.org/r/5815/#review4789

Ship It!
https://hg.mozilla.org/mozilla-central/rev/ad46c4efdc6b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox39: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 39
Comment on attachment 8580979 [details]
MozReview Request: bz://1145892/mcomella

This should be uplifted with bug 1122302.

Approval Request Comment
[Feature/regressing bug #]: bug 1122302
[User impact if declined]:
  Users who get null a clientrecord (I'm not sure the STR - maybe never having signed up for sync befor) will crash

[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: 
  Low - null check.

[String/UUID change made/needed]: None
Attachment #8580979 - Flags: approval-mozilla-aurora?
Attachment #8580979 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Duplicate of this bug: 1146357
Attachment #8580979 - Attachment is obsolete: true
Attachment #8619834 - Flags: review+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.