1145909 - Use an image instead of toolbarbutton for the reading list button

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P5)

Description

[Jared Wein [:jaws] (please needinfo? me)]

+++ This bug was initially created as a clone of Bug #1140345 +++

The reader mode button in the location bar is too close to the dropdown arrow as well as adjacent location bar icons when there are any.

This could be fixed by addressing bug 1140340 and reverting most of bug 1131458.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch

Comment 2

[Florian Quèze [:florian] (PTO until August 29)]

Comment on attachment 8581003 [details] [diff] [review]
Patch

Review of attachment 8581003 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/readinglist/readinglist.inc.css
@@ +8,2 @@
>    list-style-image: url("chrome://browser/skin/readinglist/icons.svg#addpage");
> +  -moz-image-region: rect(0,14px,14px,0);

nit: add a space after each comma.

Comment 3

[Florian Quèze [:florian] (PTO until August 29)]

Comment on attachment 8581003 [details] [diff] [review]
Patch

Review of attachment 8581003 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser.xul
@@ +829,5 @@
>                         onclick="gPopupBlockerObserver.onReportButtonClick(event);"/>
> +                <image id="readinglist-addremove-button"
> +                       class="urlbar-icon"
> +                       hidden="true"
> +                       oncommand="ReadingListUI.togglePageByBrowser(gBrowser.selectedBrowser);"/>

This oncommand needs to be changed to onclick.

Comment 4

[Florian Quèze [:florian] (PTO until August 29)]

https://hg.mozilla.org/integration/fx-team/rev/baee5624e710

Comment 5

[:Gavin Sharp [email: [e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/baee5624e710

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/79bc8606e315