Use an image instead of toolbarbutton for the reading list button

RESOLVED FIXED in Firefox 38

Status

()

Product:
Firefox
Component:
Theme
Importance:
P5
normal
Status:
RESOLVED FIXED
Reported:
4 years ago
Modified:
4 years ago

People

(Reporter: jaws, Assigned: jaws)

Tracking

(Depends on: 1 bug, Blocks: 1 bug)

Version:
Trunk
Target:
Firefox 39
Points:
3
Dependency tree / graph
Bug Flags:
firefox-backlog +
qe-verify -

Firefox Tracking Flags

(firefox38 fixed)

Details

Attachments

(1 attachment)

Patch
4.68 KB, patch
florian
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
4 years ago 
+++ This bug was initially created as a clone of Bug #1140345 +++

The reader mode button in the location bar is too close to the dropdown arrow as well as adjacent location bar icons when there are any.

This could be fixed by addressing bug 1140340 and reverting most of bug 1131458.
Flags: qe-verify-
Flags: firefox-backlog+
Summary: Use an image instead of toolbarbutton for the reading view button → Use an image instead of toolbarbutton for the reading list button

Comment 2

•
4 years ago 
Comment on attachment 8581003 [details] [diff] [review]
Patch

Review of attachment 8581003 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/readinglist/readinglist.inc.css
@@ +8,2 @@
>    list-style-image: url("chrome://browser/skin/readinglist/icons.svg#addpage");
> +  -moz-image-region: rect(0,14px,14px,0);

nit: add a space after each comma.
Attachment #8581003 - Flags: review?(florian) → review+

Comment 3

•
4 years ago 
Comment on attachment 8581003 [details] [diff] [review]
Patch

Review of attachment 8581003 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/base/content/browser.xul
@@ +829,5 @@
>                         onclick="gPopupBlockerObserver.onReportButtonClick(event);"/>
> +                <image id="readinglist-addremove-button"
> +                       class="urlbar-icon"
> +                       hidden="true"
> +                       oncommand="ReadingListUI.togglePageByBrowser(gBrowser.selectedBrowser);"/>

This oncommand needs to be changed to onclick.
Iteration: 38.3 - 23 Feb → 39.2 - 23 Mar

Comment 5

•
4 years ago 
https://hg.mozilla.org/mozilla-central/rev/baee5624e710
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
You need to log in before you can comment on or make changes to this bug.