1146488 - Add back drop shadow to share overlay

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Removed in bug 1127901 when the styles were getting cleaned up.

Comment 1

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Hey Mike,

How hard is it to reuse the shadow that Chenxia used for our doorhangers?

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Anthony Lam (:antlam) from comment #1)
> How hard is it to reuse the shadow that Chenxia used for our doorhangers?

Chenxia, I'd think it'd be easier to move to CardView (though I'm not sure how large the cardview dep is...) rather than apply this shadow everywhere – what do you think? It might remove all the rounded-corner hacks too. :)

Comment 3

[Chenxia Liu [:liuche]]

If you end up moving to CardView in bug 1203730, I'm happy to switch to it for all the doorhanger stuff!

Comment 4

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.