1146698 - Chat Messages added to logs just before shutdown may not be indexed by gloda

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[aleth [:aleth]]

STR
Send a message and shutdown immediately.
The message is in the logs, but not added to the gloda index.

Comment 1

[aleth [:aleth]]

Gloda forgets queued indexing jobs on shutdown.

On restart, the log is found on log sweep and an index is correctly scheduled with isNew = false.
However, it appears the gloda indexer does not find the previous entry to update it, as the glodaconv passed to grokNounItem doesn't have an id, in particular not the id of the existing entry.

I'm not sure if this was ever expected to work?

Comment 3

[Florian Quèze [:florian]]

(In reply to aleth [:aleth] from comment #1)

> I'm not sure if this was ever expected to work?

Not sure either. I think we had to ship, so we didn't look too deep into corner cases.

Comment 4

[Kent James (:rkent)]

I don't see any progress on this, we are not going to block on it, so removing tracking.

Comment 5

[aleth [:aleth]]

Attachment: getidfrompath.diff

Comment 6

[(inactive) Nihanth Subramanya [:nhnt11]]

Comment on attachment 8600652 [details] [diff] [review]
getidfrompath.diff

Review of attachment 8600652 [details] [diff] [review]:
-----------------------------------------------------------------

Seems to do the trick. Thanks!

Comment 7

[aleth [:aleth]]

Attachment: getidfrompath.diff v2

Works consistently also in the edge case of multiple nonempty result sets.

Comment 8

[Florian Quèze [:florian]]

Comment on attachment 8600704 [details] [diff] [review]
getidfrompath.diff v2

Review of attachment 8600704 [details] [diff] [review]:
-----------------------------------------------------------------

I won't pretend to fully understand all of this code today, but the patch (and the explanations I got on IRC) seem to make sense.

Comment 9

[aleth [:aleth]]

https://hg.mozilla.org/comm-central/rev/b5783f19e00a

Comment 10

[aleth [:aleth]]

Comment on attachment 8600704 [details] [diff] [review]
getidfrompath.diff v2

[Approval Request Comment]
User impact if declined: Incomplete gloda search results. It would be nice to have these gloda issues fixed from 38 onwards.
Testing completed (on c-c, etc.): Would be helpful if some more people could check their conversations are getting fully indexed now this has landed.

Comment 11

[aleth [:aleth]]

Comment on attachment 8600704 [details] [diff] [review]
getidfrompath.diff v2

As per "testing" in comment 10, let's hold off on uplifting this one for a bit.

Comment 12

[aleth [:aleth]]

Comment on attachment 8600704 [details] [diff] [review]
getidfrompath.diff v2

[Approval Request Comment]
User impact if declined: Incomplete gloda search results. It would be nice to have these gloda issues fixed from 38 onwards.
Testing completed (on c-c, etc.): Has been landed for a while now without further bug reports and verified fixed twice.

Comment 13

[Kent James (:rkent)]

Comment on attachment 8600704 [details] [diff] [review]
getidfrompath.diff v2

https://hg.mozilla.org/releases/comm-esr38/rev/feb3c734a00d