Closed Bug 1146698 Opened 9 years ago Closed 9 years ago

Chat Messages added to logs just before shutdown may not be indexed by gloda

Categories

(Thunderbird :: Instant Messaging, defect)

x86
macOS
defect
Not set
normal

Tracking

(thunderbird38- affected, thunderbird40 fixed, thunderbird_esr3841+ fixed)

RESOLVED FIXED
Thunderbird 40.0
Tracking Status
thunderbird38 - affected
thunderbird40 --- fixed
thunderbird_esr38 41+ fixed

People

(Reporter: aleth, Assigned: aleth)

References

Details

Attachments

(1 file, 1 obsolete file)

STR
Send a message and shutdown immediately.
The message is in the logs, but not added to the gloda index.
Summary: Messages added to logs just before shutdown may not be indexed by gloda → Chat Messages added to logs just before shutdown may not be indexed by gloda
Gloda forgets queued indexing jobs on shutdown.

On restart, the log is found on log sweep and an index is correctly scheduled with isNew = false.
However, it appears the gloda indexer does not find the previous entry to update it, as the glodaconv passed to grokNounItem doesn't have an id, in particular not the id of the existing entry.

I'm not sure if this was ever expected to work?
Flags: needinfo?(florian)
(In reply to aleth [:aleth] from comment #1)

> I'm not sure if this was ever expected to work?

Not sure either. I think we had to ship, so we didn't look too deep into corner cases.
Flags: needinfo?(florian)
I don't see any progress on this, we are not going to block on it, so removing tracking.
Attached patch getidfrompath.diff (obsolete) — Splinter Review
Assignee: nobody → aleth
Status: NEW → ASSIGNED
Attachment #8600652 - Flags: review?(nhnt11)
Comment on attachment 8600652 [details] [diff] [review]
getidfrompath.diff

Review of attachment 8600652 [details] [diff] [review]:
-----------------------------------------------------------------

Seems to do the trick. Thanks!
Attachment #8600652 - Flags: review?(nhnt11) → review+
Attachment #8600652 - Flags: review?(florian)
Works consistently also in the edge case of multiple nonempty result sets.
Attachment #8600652 - Attachment is obsolete: true
Attachment #8600652 - Flags: review?(florian)
Attachment #8600704 - Flags: review?(florian)
Comment on attachment 8600704 [details] [diff] [review]
getidfrompath.diff v2

Review of attachment 8600704 [details] [diff] [review]:
-----------------------------------------------------------------

I won't pretend to fully understand all of this code today, but the patch (and the explanations I got on IRC) seem to make sense.
Attachment #8600704 - Flags: review?(florian) → review+
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 40.0
Comment on attachment 8600704 [details] [diff] [review]
getidfrompath.diff v2

[Approval Request Comment]
User impact if declined: Incomplete gloda search results. It would be nice to have these gloda issues fixed from 38 onwards.
Testing completed (on c-c, etc.): Would be helpful if some more people could check their conversations are getting fully indexed now this has landed.
Attachment #8600704 - Flags: approval-comm-beta?
Attachment #8600704 - Flags: approval-comm-aurora?
Comment on attachment 8600704 [details] [diff] [review]
getidfrompath.diff v2

As per "testing" in comment 10, let's hold off on uplifting this one for a bit.
Attachment #8600704 - Flags: approval-comm-beta?
Attachment #8600704 - Flags: approval-comm-aurora?
Comment on attachment 8600704 [details] [diff] [review]
getidfrompath.diff v2

[Approval Request Comment]
User impact if declined: Incomplete gloda search results. It would be nice to have these gloda issues fixed from 38 onwards.
Testing completed (on c-c, etc.): Has been landed for a while now without further bug reports and verified fixed twice.
Attachment #8600704 - Flags: approval-comm-esr38?
Comment on attachment 8600704 [details] [diff] [review]
getidfrompath.diff v2

https://hg.mozilla.org/releases/comm-esr38/rev/feb3c734a00d
Attachment #8600704 - Flags: approval-comm-esr38? → approval-comm-esr38+
You need to log in before you can comment on or make changes to this bug.