Closed
Bug 1146753
Opened 10 years ago
Closed 10 years ago
When test text_selection_test.js, we should wait for caret time before proceeding next action.
Categories
(Firefox OS Graveyard :: Gaia::System, defect, P4)
Firefox OS Graveyard
Gaia::System
Tracking
(blocking-b2g:2.2+, b2g-v2.2 fixed, b2g-master fixed)
People
(Reporter: mtseng, Assigned: mtseng)
References
Details
Attachments
(1 file)
|
46 bytes,
text/x-github-pull-request
|
gduan
:
review+
bajaj
:
approval-gaia-v2.2+
|
Details | Review |
In Bug 1021499, we enlarge touch area for caret. So if we don't wait caret timeout then we cannot select word because we would always tap on the caret.
|
||
Comment 1•10 years ago
|
||
|
Assignee | |
Updated•10 years ago
|
Attachment #8582189 -
Flags: review?(gduan)
|
||
Updated•10 years ago
|
Attachment #8582189 -
Flags: review?(gduan) → review+
|
|
||
Comment 2•10 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Comment 3•10 years ago
|
||
Comment on attachment 8582189 [details] [review]
[gaia] mephisto41:bug1146753 > mozilla-b2g:master
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Some tests would fail if bug 1021499 is landed.
[Testing completed]: On master.
[Risk to taking this patch] (and alternatives if risky): very low risk
[String changes made]: none
Attachment #8582189 -
Flags: approval-gaia-v2.2?
|
||
Comment 4•10 years ago
|
||
Set blocking v2.2 flag to fix gaia integration test.
blocking-b2g: --- → 2.2+
|
||
Comment 5•10 years ago
|
||
still waiting for 1021499 to be ready before acting on this appproval
|
|
Assignee | |
Comment 6•10 years ago
|
||
Hi :bajaj,
bug 1021499 is ready. Please approve this patch, thanks :)
Flags: needinfo?(bbajaj)
|
|
||
Updated•10 years ago
|
Flags: needinfo?(bbajaj)
Attachment #8582189 -
Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
|
||
Comment 7•10 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•