When test text_selection_test.js, we should wait for caret time before proceeding next action.

RESOLVED FIXED in 2.2 S9 (3apr)

Status

Product:
Firefox OS Graveyard
Component:
Gaia::System
Type:
defect
Importance:
P4
normal
Status:
RESOLVED FIXED
Reported:
4 years ago
Modified:
4 years ago

People

(Reporter: mtseng, Assigned: mtseng)

Tracking

Version:
unspecified
Target:
2.2 S9 (3apr)
Dependency tree / graph

Firefox Tracking Flags

(blocking-b2g:2.2+, b2g-v2.2 fixed, b2g-master fixed)

Details

Attachments

(1 attachment)

[gaia] mephisto41:bug1146753 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
gduan
: review+
bajaj
: approval-gaia-v2.2+
Details | Review
(Assignee)

Description

•
4 years ago 
In Bug 1021499, we enlarge touch area for caret. So if we don't wait caret timeout then we cannot select word because we would always tap on the caret.
Attachment #8582189 - Flags: review?(gduan)
Attachment #8582189 - Flags: review?(gduan) → review+

Comment 2

•
4 years ago 
master: https://github.com/mozilla-b2g/gaia/commit/5846adb230f284921176b5ac3a1d7cb6fd4334f8
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
 (Assignee)

Comment 3

•
4 years ago 
Comment on attachment 8582189 [details] [review]
[gaia] mephisto41:bug1146753 > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: Some tests would fail if bug 1021499 is landed.
[Testing completed]: On master.
[Risk to taking this patch] (and alternatives if risky): very low risk
[String changes made]: none
Attachment #8582189 - Flags: approval-gaia-v2.2?

Comment 4

•
4 years ago 
Set blocking v2.2 flag to fix gaia integration test.
blocking-b2g: --- → 2.2+

Comment 5

•
4 years ago 
still waiting for 1021499 to be ready before acting on this appproval
 (Assignee)

Comment 6

•
4 years ago 
Hi :bajaj,
bug 1021499 is ready. Please approve this patch, thanks :)
Flags: needinfo?(bbajaj)
Flags: needinfo?(bbajaj)
Attachment #8582189 - Flags: approval-gaia-v2.2? → approval-gaia-v2.2+
You need to log in before you can comment on or make changes to this bug.