1146766 - 'follow/stop following' doesn't indicate changes are immediated (eg. the "cc following" count isn't updated)

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, defect)

Description

[:glob ✱]

when you follow/stop-following a bug, the blurb in the people module which states how many people are following isn't updated immediately.

Comment 1

[Daniel Holbert [:dholbert]]

FWIW, I generated a bunch of useless bugmail last night due to this bug.

(I was trying to figure out how to un-CC myself from a bug.  I tried clicking 'stop following' a few times, but my email address was still displayed in the "CC" list, so I clicked "Follow" again to Undo whatever I'd just done. And then I wondered whether this controlled the "Never email me about this bug" checkbox -- so I tried clicking the button again to see if it controlled that checkbox. It did not. Mystified, I clicked "Follow" again to undo whatever I'd just done. I was left assuming that I simply could not un-CC myself.

Several minutes later, I noticed the flood of bugmail arrive for all the bug edits (to the CC list) that I'd unknowingly just been performing.)

Comment 3

[:glob ✱]

(Ed Morley [:emorley] from bug 1170962)
> I think that in addition to some indication on the follow button itself,
> after pressing it, the "Add me to CC list (follow this bug)" checkbox at the
> end of the page (by the comment box) should disappear.

Comment 4

[:glob ✱]

Attachment: 1146766_1.patch

when clicking on 'follow':
- update the "N people" text
- invalidate the cached people list
- trigger a refresh of the people list if it's visible
- show a message "You are now following this bug" / "You are no longer following this bug"
- hide/show "add me to the cc list"

Comment 5

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8672481 [details] [diff] [review]
1146766_1.patch

Review of attachment 8672481 [details] [diff] [review]:
-----------------------------------------------------------------

r- because the patch doesn't apply, but f+ because the code looks sane.

Comment 6

[:glob ✱]

Attachment: 1146766_2.patch

i suspect i bitrotted my own patch very soon after attaching it here :)

Comment 7

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8673448 [details] [diff] [review]
1146766_2.patch

Review of attachment 8673448 [details] [diff] [review]:
-----------------------------------------------------------------

it behaves admirably even when I spam the follow button. will do a full review in the morning.

Comment 8

[Dylan Hardison [:dylan] (he/him)]

Comment on attachment 8673448 [details] [diff] [review]
1146766_2.patch

Review of attachment 8673448 [details] [diff] [review]:
-----------------------------------------------------------------

r=dylan

Comment 9

[:glob ✱]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   0e11b4a..5265c09  master -> master