1146853 - ship-it: when selecting a proposed version in the "Version:" field, automatically retrieves the appropriate changeset

Status: RESOLVED FIXED

(Release Engineering :: Applications: Shipit, defect)

Description

[Sylvestre Ledru [:Sylvestre]]

When entering a version for a release (example: 36.0), we should update the "Mozilla Revision" with the last changeset.

The information can be retrieved the last changeset from:
https://hg.mozilla.org/releases/mozilla-release/

beta:
https://hg.mozilla.org/releases/mozilla-beta/

esr:
https://hg.mozilla.org/releases/mozilla-esr31/

and thunderbird


Code available:
https://github.com/mozilla/ship-it/

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

URLs like https://hg.mozilla.org/releases/mozilla-release/json-pushes are ideal for this. Eg it currently ends with
 "700": {
  "changesets": [
   "2592523e1eb02d3a41268f0514a554d3353836d1", 
   "4d306a83ae1b8faadd5a1572c6284fb2bf848763", 
   "b8c1a399905ddc0371ce9fa6b9efee6bd249739d", 
   "fadc9f270e9f7d2f11605f8477a1053132023f19", 
   "07c827be741f4a07f5ab8bb723141553e83ceeec"
  ], 
  "date": 1427200191, 
  "user": "[e-mail]"
 }
}

and 07c827be741f is the current tip.

Comment 2

[Tyler Ebel]

please assign to me, I will need help. Who is the brave soul!?

Comment 3

[Sylvestre Ledru [:Sylvestre]]

(In reply to Tyler Ebel from comment #2)
> I will need help. Who is the brave soul!?
I can probably help, please ask your questions :)

Comment 4

[Tyler Ebel]

#1 Do I need to setup a Personal Development Master ? If so, I need credentials added. If not, could you let me know where to start in setting up a local dev ?
https://wiki.mozilla.org/ReleaseEngineering/How_To/Setup_Personal_Development_Master

Thanks!

Comment 5

[Sylvestre Ledru [:Sylvestre]]

You don't need anything:
https://github.com/mozilla/ship-it/ will be enough for this project

Comment 6

[Tyler Ebel]

ok, thanks. Ill look at and get back to you.

Comment 7

[Sylvestre Ledru [:Sylvestre]]

Johan, is it something you could help with? Thanks

Comment 8

[Johan Lorenzo [:jlorenzo]]

Sure! I'll probably give it a try next week. Keeping the NI in the meantime.

Comment 9

[Johan Lorenzo [:jlorenzo]]

Attachment: PR

The fetching mechanism is similar to the one used for Elmo.

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8803876 [details] [review]
PR

Commented on github

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Johan, we should fix this one, right?

Comment 12

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8803876 [details] [review]
PR

I agree. I rebased the patch. The only conflicts were related the renaming of downloadMessage.

I tested it again manually and didn't notice issues. r? Sylvestre

Comment 13

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8803876 [details] [review]
PR

PR approved by Sylvestre in Github: https://github.com/mozilla-releng/ship-it/pull/132#pullrequestreview-17204051

Comment 14

[Johan Lorenzo [:jlorenzo]]

Landed in master at: https://github.com/mozilla-releng/ship-it/commit/c6122a633af820af9af5a07a96cd7e8dc6b3f471

Comment 15

[Rail Aliiev [:rail]]

Deployed today