1339118 - "Gimme a firefox" forgets about the revision it auto-filled

Status: RESOLVED FIXED

(Release Engineering :: Applications: Shipit, defect)

Description

[Julien Cristau [:jcristau]]

STR:
- submit a new release
- enter a version number, the revision is filled in automatically
- click "gimme a firefox" (without focusing the revision field)
- get back an error about missing mozilla revision

Comment 1

[Johan Lorenzo [:jlorenzo]]

Attachment: PR

Here comes the best JS hack. :julienw, a JS front end jedi, told me about this trick yesterday.

We discussed about the different strategies like: 
* caching the results of the AJAX request (doesn't work because of async)
* using `tip` instead of a fixed revision, let release-runner resolve it, and edit the ship-it db (doesn't work because release management may need to not use the tip)
* removing the `change` event so people will have to only pick a version from the list (doesn't work with an empty database)

What do you think of it, rail?

Comment 2

[Rail Aliiev [:rail]]

Comment on attachment 8839398 [details] [review]
PR

What can possibly go wrong?! :)

Comment 3

[Johan Lorenzo [:jlorenzo]]

Landed in master at https://github.com/mozilla-releng/ship-it/commit/635a035c2e24d359abd47526568fae0d0f00aaaa