1146875 - Fix the leak-gauge.html broken

Status: RESOLVED FIXED

(Core :: General, defect)

Description

[YF (Yang)]

Attachment: patch v1

Fix the attachment 537675 [details] [diff] [review] of Bug 662403 broken the script, and add a encoding declaration to avoid a warning for the file opened on local.


No modify the $Id, I uncertainty its specification.

No a bug number in this patch, because I unable to predict it. Any practices or techniques for this case?

Who is fit to review this patch? I did not find (in https://bugzilla.mozilla.org/page.cgi?id=review_suggestions.html or elsewhere), please assignment if you know, thanks.

Comment 1

[Andrew McCreight (out until 2026) [:mccr8]]

Comment on attachment 8582375 [details] [diff] [review]
patch v1

dbaron is probably most familiar with this.

Comment 2

[Andrew McCreight (out until 2026) [:mccr8]]

I don't know that we still use leak-gauge for anything in our infrastructure.

Comment 3

[YF (Yang)]

(In reply to Andrew McCreight [:mccr8] from comment #2)
> I don't know that we still use leak-gauge for anything in our infrastructure.

Just the https://developer.mozilla.org/en-US/docs/Mozilla/Performance page mentioned this tool...

Comment 4

[YF (Yang)]

(In reply to Andrew McCreight [:mccr8] from comment #1)
> Comment on attachment 8582375 [details] [diff] [review]
> patch v1
> 
> dbaron is probably most familiar with this.

And thank you, I really forget to specify the author, just dedicated to finding a core peer, but the role does not seem to exist.

Comment 5

[Andrew McCreight (out until 2026) [:mccr8]]

(In reply to YF (Yang) from comment #4)
> And thank you, I really forget to specify the author, just dedicated to
> finding a core peer, but the role does not seem to exist.

Yeah, I think this particular file falls under the "Code Analysis and Debugging Tools" module, as you can see from the listing of things under "source dirs".  But it isn't very obvious.

Comment 6

[YF (Yang)]

(In reply to Andrew McCreight [:mccr8] from comment #5)
> (In reply to YF (Yang) from comment #4)
> > And thank you, I really forget to specify the author, just dedicated to
> > finding a core peer, but the role does not seem to exist.
> 
> Yeah, I think this particular file falls under the "Code Analysis and
> Debugging Tools" module, as you can see from the listing of things under
> "source dirs".  But it isn't very obvious.

OK, I found it on https://wiki.mozilla.org/Modules/Core#Code_Analysis_and_Debugging_Tools, looks the https://bugzilla.mozilla.org/page.cgi?id=review_suggestions.html not a complete and good place.


Maybe, we should marked the tool on MDN? if it is already deprecated / unreliable.

Comment 7

[Andrew McCreight (out until 2026) [:mccr8]]

(This isn't part of anything we run on tree-herder, so it doesn't need a try run prior to checkin, IMO.)

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/1ffda5f76e3d

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/1ffda5f76e3d