Last Comment Bug 662403 - reftest-analyzer is broken
: reftest-analyzer is broken
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: Trunk
: All All
: -- major (vote)
: mozilla7
Assigned To: Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
:
Mentors:
Depends on: 1146875
Blocks: 661876
  Show dependency treegraph
 
Reported: 2011-06-06 15:24 PDT by Boris Zbarsky [:bz]
Modified: 2015-03-24 06:23 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (1.50 KB, patch)
2011-06-06 15:31 PDT, Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
no flags Details | Diff | Splinter Review
Patch (1.48 KB, patch)
2011-06-06 15:44 PDT, Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
no flags Details | Diff | Splinter Review
Patch (3.25 KB, patch)
2011-06-06 16:04 PDT, Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)
bzbarsky: review+
Details | Diff | Splinter Review

Description Boris Zbarsky [:bz] 2011-06-06 15:24:24 PDT
In particular, it uses getAsText on nsIDOMFile.
Comment 1 Boris Zbarsky [:bz] 2011-06-06 15:25:59 PDT
Also, leak-gauge is broken in the same way.
Comment 2 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-06-06 15:31:56 PDT
Created attachment 537660 [details] [diff] [review]
Patch

If somebody could take this for a spin that'd be great.
Comment 3 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-06-06 15:44:09 PDT
Created attachment 537666 [details] [diff] [review]
Patch
Comment 4 Boris Zbarsky [:bz] 2011-06-06 15:57:48 PDT
What about leak-gauge?
Comment 5 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-06-06 16:04:54 PDT
Created attachment 537675 [details] [diff] [review]
Patch

leak-gauge changes are untested, but I think they're right.
Comment 6 Boris Zbarsky [:bz] 2011-06-06 16:09:55 PDT
Comment on attachment 537675 [details] [diff] [review]
Patch

r=me
Comment 7 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-06-07 09:58:21 PDT
http://hg.mozilla.org/mozilla-central/rev/17dacc2cf5ae
Comment 8 Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary) 2011-06-07 10:04:29 PDT
Once more, with feeling

http://hg.mozilla.org/mozilla-central/rev/33fd438b74ad

Note You need to log in before you can comment on or make changes to this bug.