1146946 - TypeError: this.selectedItem is null from sidebar.js when using the up/down key when the list is empty.

Status: VERIFIED FIXED

(Firefox Graveyard :: Reading List, defect, P4)

Comment 1

[Blake Winton (:bwinton) (:☕️)]

Attachment: MozReview Request: bz://1146946/bwinton

/r/5961 - Bug 1146946 - Handle empty selections in sidebar.js when using the up/down key. r=florian

Pull down this commit:

hg pull review -r 0196767ea412d454c3bcf80a5dc5a889e2aa2937

Comment 2

[Blake Winton (:bwinton) (:☕️)]

https://reviewboard.mozilla.org/r/5959/#review4907

I figured we should do nothing, just like for the enter key.

(Arguably we want to be a little more clever, and only do nothing if there are no entries.  Let me know if you want me to update the code to do that instead.)

Comment 3

[Florian Quèze [:florian]]

(In reply to Blake Winton (:bwinton) from comment #2)
> https://reviewboard.mozilla.org/r/5959/#review4907
> 
> I figured we should do nothing, just like for the enter key.

How will we make a selection from the keyboard if the up/down keys do nothing when there's no existing selection?

Comment 4

[Blake Winton (:bwinton) (:☕️)]

The mouse?  ;)

Okay, I'll switch to ignoring up/down only when there are no entries…

Comment 5

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 8582467 [details]
MozReview Request: bz://1146946/bwinton

/r/5961 - Bug 1146946 - Handle empty selections in sidebar.js when using the up/down key. r=florian
/r/5973 - Bug 1146946 - Handle empty lists in sidebar.js when using the up/down key. r=florian

Pull down these commits:

hg pull review -r 417f79c9bacaacc8ff8a0e2fa23efb859b039463

Comment 6

[Florian Quèze [:florian]]

Comment on attachment 8582467 [details]
MozReview Request: bz://1146946/bwinton

https://reviewboard.mozilla.org/r/5959/#review4933

::: browser/components/readinglist/sidebar.js
(Diff revision 2)
> +      if (this.list.children.length == 0) {

if (!this.numItems)

::: browser/components/readinglist/sidebar.js
(Diff revision 2)
> +      if (this.list.children.length == 0) {

same here

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Comment on attachment 8582467 [details]
MozReview Request: bz://1146946/bwinton

/r/5961 - Bug 1146946 - Handle empty selections in sidebar.js when using the up/down key. r=florian
/r/5973 - Bug 1146946 - Handle empty lists in sidebar.js when using the up/down key. r=florian
/r/5981 - Bug 1146946 - Handle empty lists in sidebar.js when using the up/down key. r=florian

Pull down these commits:

hg pull review -r e60e7e4984534ce0c861160ebfd37becc9afb8e8

Comment 8

[Florian Quèze [:florian]]

Comment on attachment 8582467 [details]
MozReview Request: bz://1146946/bwinton

https://reviewboard.mozilla.org/r/5959/#review4935

Ship It!

Comment 9

[Blake Winton (:bwinton) (:☕️)]

Attachment: A version of the patch ready for checkin.

Carrying forward r=florian.

Try results at https://treeherder.mozilla.org/#/jobs?repo=try&revision=6918c85e950f

Comment 10

[Florian Quèze [:florian]]

https://hg.mozilla.org/integration/fx-team/rev/a4cab686efdd

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a4cab686efdd

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5a005b821dae

Comment 13

[Andrei Vaida [:avaida]]

Verified fixed on Nightly 39.0a1 (2015-03-29) and Aurora 38.0a2 (2015-03-29), using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.

Comment 14

[David Lawrence [:dkl]]

Mistakenly filed against Firefox 38 and should be instead 38 Branch. Sorry for the spam. dkl