Closed Bug 1146946 Opened 5 years ago Closed 5 years ago

TypeError: this.selectedItem is null from sidebar.js when using the up/down key when the list is empty.

Categories

(Firefox Graveyard :: Reading List, defect, P4)

38 Branch
x86
All
defect

Tracking

(firefox38 verified, firefox39 verified)

VERIFIED FIXED
Firefox 39
Tracking Status
firefox38 --- verified
firefox39 --- verified

People

(Reporter: bwinton, Assigned: bwinton)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Flags: qe-verify+
QA Contact: andrei.vaida
/r/5961 - Bug 1146946 - Handle empty selections in sidebar.js when using the up/down key. r=florian

Pull down this commit:

hg pull review -r 0196767ea412d454c3bcf80a5dc5a889e2aa2937
Attachment #8582467 - Flags: review?(florian)
https://reviewboard.mozilla.org/r/5959/#review4907

I figured we should do nothing, just like for the enter key.

(Arguably we want to be a little more clever, and only do nothing if there are no entries.  Let me know if you want me to update the code to do that instead.)
(In reply to Blake Winton (:bwinton) from comment #2)
> https://reviewboard.mozilla.org/r/5959/#review4907
> 
> I figured we should do nothing, just like for the enter key.

How will we make a selection from the keyboard if the up/down keys do nothing when there's no existing selection?
The mouse?  ;)

Okay, I'll switch to ignoring up/down only when there are no entries…
Comment on attachment 8582467 [details]
MozReview Request: bz://1146946/bwinton

/r/5961 - Bug 1146946 - Handle empty selections in sidebar.js when using the up/down key. r=florian
/r/5973 - Bug 1146946 - Handle empty lists in sidebar.js when using the up/down key. r=florian

Pull down these commits:

hg pull review -r 417f79c9bacaacc8ff8a0e2fa23efb859b039463
Comment on attachment 8582467 [details]
MozReview Request: bz://1146946/bwinton

https://reviewboard.mozilla.org/r/5959/#review4933

::: browser/components/readinglist/sidebar.js
(Diff revision 2)
> +      if (this.list.children.length == 0) {

if (!this.numItems)

::: browser/components/readinglist/sidebar.js
(Diff revision 2)
> +      if (this.list.children.length == 0) {

same here
Attachment #8582467 - Flags: review?(florian)
Comment on attachment 8582467 [details]
MozReview Request: bz://1146946/bwinton

/r/5961 - Bug 1146946 - Handle empty selections in sidebar.js when using the up/down key. r=florian
/r/5973 - Bug 1146946 - Handle empty lists in sidebar.js when using the up/down key. r=florian
/r/5981 - Bug 1146946 - Handle empty lists in sidebar.js when using the up/down key. r=florian

Pull down these commits:

hg pull review -r e60e7e4984534ce0c861160ebfd37becc9afb8e8
Attachment #8582467 - Flags: review?(florian)
Comment on attachment 8582467 [details]
MozReview Request: bz://1146946/bwinton

https://reviewboard.mozilla.org/r/5959/#review4935

Ship It!
Attachment #8582467 - Flags: review?(florian) → review+
Carrying forward r=florian.

Try results at https://treeherder.mozilla.org/#/jobs?repo=try&revision=6918c85e950f
Attachment #8582467 - Attachment is obsolete: true
Attachment #8582630 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/a4cab686efdd
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 39
Verified fixed on Nightly 39.0a1 (2015-03-29) and Aurora 38.0a2 (2015-03-29), using Windows 7 (x64), Ubuntu 14.04 (x64) and Mac OS X 10.9.5.
Status: RESOLVED → VERIFIED
Mistakenly filed against Firefox 38 and should be instead 38 Branch. Sorry for the spam. dkl
Version: Firefox 38 → 38 Branch
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.