Closed
Bug 1147006
Opened 6 years ago
Closed 6 years ago
TB shows instructions with [File] - [Offline] - [Synchronize] instead of [Download/Sync Now]
Categories
(Thunderbird :: General, defect)
Thunderbird
General
Tracking
(thunderbird40 fixed)
RESOLVED
FIXED
Thunderbird 40.0
Tracking | Status | |
---|---|---|
thunderbird40 | --- | fixed |
People
(Reporter: pollti, Assigned: pollti)
Details
Attachments
(1 file, 7 obsolete files)
3.21 KB,
patch
|
Details | Diff | Splinter Review |
When TB is offline and a message body could not be downloaded, TB shows the following message:
>The body of this message has not been downloaded from
>the server for reading offline. To read this message,
>you must reconnect to the network, choose Offline from
>the File menu and then uncheck Work Offline.
>In the future, you can select which messages or folders to read offline. To do
>this, choose Offline from the file menu and then select Synchronize. You can
>adjust the Disk Space preference to prevent the downloading of large messages.
"Synchronize" should be replaced by "Download/Sync Now…"
Attachment #8582517 -
Flags: review?(bwinton)
Comment 1•6 years ago
|
||
Comment on attachment 8582517 [details] [diff] [review] patch Review of attachment 8582517 [details] [diff] [review]: ----------------------------------------------------------------- Other than the nit below, I like it. Adding Neil for the review of the Suite code. ::: mail/locales/en-US/chrome/messenger/messenger.properties @@ +306,5 @@ > the server for reading offline. To read this message, \ > you must reconnect to the network, choose Offline from \ > the File menu and then uncheck Work Offline. \ > In the future, you can select which messages or folders to read offline. To do \ > +this, choose Offline from the file menu and then select Download/Sync Now…. \ I would remove the … from this, since it doesn't add any benefit, and looks confusing.
Attachment #8582517 -
Flags: review?(neil)
Attachment #8582517 -
Flags: review?(bwinton)
Attachment #8582517 -
Flags: review+
Comment 2•6 years ago
|
||
Comment on attachment 8582517 [details] [diff] [review] patch Whoa, regression from bug 71125 ;-) Unfortunately due to our sucky l10n process we need to change the string key (here and in the C++) so that localisers notice the problem.
Attachment #8582517 -
Flags: review?(neil) → review-
Assignee | ||
Comment 3•6 years ago
|
||
Thanks for your feedback! This removes the "…". Neil, could you explain, what I have to do, please? (I'm sorry - I'm not very familiar with TB l10n update processes.)
Attachment #8582517 -
Attachment is obsolete: true
Flags: needinfo?(neil)
Assignee | ||
Updated•6 years ago
|
Summary: TB shows instructions with [File] - [Offline] - [Synchronize] instead of [Download/Sync Now…] → TB shows instructions with [File] - [Offline] - [Synchronize] instead of [Download/Sync Now]
Comment 4•6 years ago
|
||
Comment on attachment 8583165 [details] [diff] [review] patch #2 > nocachedbodybody=The body of this message has not been downloaded from \ The name "nocachedbodybody" identifies this message. Unfortunately if you change the message without changing the name, then localisers will not realise that the message has changed, as the l10n dashboard will only display differences in names. You therefore need to change the name, not only in these two files, but also in the C++ file that also references this message.
Flags: needinfo?(neil)
Assignee | ||
Comment 5•6 years ago
|
||
Thanks! This should update the string's name in all the files.
Attachment #8583165 -
Attachment is obsolete: true
Attachment #8584977 -
Flags: review?(neil)
Assignee | ||
Updated•6 years ago
|
Attachment #8584977 -
Flags: review?(bwinton)
Comment 6•6 years ago
|
||
Comment on attachment 8584977 [details] [diff] [review] patch, v3 > nocachedbodybodyupdated=The body of this message has not been downloaded from \ Somehow this isn't showing up as a change in your patch? Also, when changing strings, we normally use a numeric suffix, in case the string ever needs to be changed again (i.e. the suffix is 2, 3, etc. for each subsequent change).
Assignee | ||
Comment 7•6 years ago
|
||
I don't see the reason for the not working changes at the moment. I'll try to fix it next week.
Flags: needinfo?(pollti)
Comment 8•6 years ago
|
||
Comment on attachment 8584977 [details] [diff] [review] patch, v3 I'm going to wait for the working patch, but this seems pretty good so far. ;)
Attachment #8584977 -
Flags: review?(bwinton)
Assignee | ||
Comment 9•6 years ago
|
||
I'm sorry for my mistakes. Hopefully, this one will work properly.
Attachment #8584977 -
Attachment is obsolete: true
Attachment #8584977 -
Flags: review?(neil)
Flags: needinfo?(pollti)
Attachment #8588973 -
Flags: review?(neil)
Assignee | ||
Updated•6 years ago
|
Attachment #8588973 -
Flags: review?(bwinton)
Comment 10•6 years ago
|
||
Comment on attachment 8588973 [details] [diff] [review] patch, v4 This looks OK by code inspection; I didn't actually apply the patch.
Attachment #8588973 -
Flags: review?(neil) → review+
Comment 11•6 years ago
|
||
Comment on attachment 8588973 [details] [diff] [review] patch, v4 Review of attachment 8588973 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me too!
Attachment #8588973 -
Flags: review?(bwinton) → review+
Assignee | ||
Comment 12•6 years ago
|
||
Thanks! What are the next steps here? / Is there anything I can do?
Comment 13•6 years ago
|
||
Put "checkin-needed" in the keywords, and someone will check the code in for you!
Assignee | ||
Updated•6 years ago
|
Keywords: checkin-needed
Thank you for working on this. There are several issues with the patch, please fix them and resubmit (feel free to ping me on IRC if you have questions). Output from the console: unable to find 'suite/locales/en-US/chrome/messenger/messenger.properties' for patching 1 out of 1 hunks FAILED -- saving rejects to file suite/locales/en-US/chrome/messenger/messenger.properties.rej patching file mailnews/base/util/nsMsgIncomingServer.cpp Hunk #1 FAILED at 1607 1 out of 1 hunks FAILED -- saving rejects to file mailnews/base/util/nsMsgIncomingServer.cpp.rej patch failed, unable to continue (try -v) cleaning up working directory...done abort: invalid date: 'Mid Apr 07 10:32:00 2015 +0100'
Keywords: checkin-needed
Assignee | ||
Comment 15•6 years ago
|
||
Two fixes. Thanks, Archaeopteryx!
Attachment #8588973 -
Attachment is obsolete: true
Assignee | ||
Comment 16•6 years ago
|
||
Attachment #8594357 -
Attachment is obsolete: true
Assignee | ||
Comment 17•6 years ago
|
||
[added missing whitspace]
Attachment #8594361 -
Attachment is obsolete: true
Assignee | ||
Comment 18•6 years ago
|
||
Attachment #8594362 -
Attachment is obsolete: true
http://hg.mozilla.org/comm-central/rev/bb995f40ce81
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-thunderbird40:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 40.0
Assignee | ||
Updated•6 years ago
|
tracking-thunderbird38:
--- → ?
Ah, string changes. No, that's way too late.
tracking-thunderbird38:
? → ---
Flags: needinfo?(rkent)
You need to log in
before you can comment on or make changes to this bug.
Description
•