1147014 - PlacesCommandHook.addLiveBookmark uses gBrowser.contentDocument, which doesn't exist in e10s browsers

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

Bug 1144149 will add contentDocumentAsCPOW and contentWindowAsCPOW shortcuts to gBrowser.

This code should probably be updated to use gBrowser.contentDocumentAsCPOW when that happens, or alternatively, gBrowser.selectedBrowser.contentDocumentAsCPOW.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

https://hg.mozilla.org/mozilla-central/file/840cfd5bc971/browser/base/content/browser-places.js#l445

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Attachment: Use contentDocumentAsCPOW instead of contentDocument in PlacesCommandHook.addLiveBookmark. r=?

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Comment on attachment 8585645 [details] [diff] [review]
Use contentDocumentAsCPOW instead of contentDocument in PlacesCommandHook.addLiveBookmark. r=?

Review of attachment 8585645 [details] [diff] [review]:
-----------------------------------------------------------------

most of this stuff could "easily" become async, fwiw, it doesn't matter that we show the dialog immediately.

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Coolbeans - thanks mak!

https://hg.mozilla.org/integration/fx-team/rev/282711269cd3

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/282711269cd3