Closed Bug 1147014 Opened 7 years ago Closed 7 years ago

PlacesCommandHook.addLiveBookmark uses gBrowser.contentDocument, which doesn't exist in e10s browsers

Categories

(Firefox :: Bookmarks & History, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 40
Tracking Status
e10s m6+ ---
firefox40 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(1 file)

Bug 1144149 will add contentDocumentAsCPOW and contentWindowAsCPOW shortcuts to gBrowser.

This code should probably be updated to use gBrowser.contentDocumentAsCPOW when that happens, or alternatively, gBrowser.selectedBrowser.contentDocumentAsCPOW.
Assignee: nobody → mconley
Depends on: 1149262
Attachment #8585645 - Flags: review?(mak77)
Comment on attachment 8585645 [details] [diff] [review]
Use contentDocumentAsCPOW instead of contentDocument in PlacesCommandHook.addLiveBookmark. r=?

Review of attachment 8585645 [details] [diff] [review]:
-----------------------------------------------------------------

most of this stuff could "easily" become async, fwiw, it doesn't matter that we show the dialog immediately.
Attachment #8585645 - Flags: review?(mak77) → review+
Coolbeans - thanks mak!

https://hg.mozilla.org/integration/fx-team/rev/282711269cd3
Whiteboard: [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/282711269cd3
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40
You need to log in before you can comment on or make changes to this bug.