Closed
Bug 1147014
Opened 10 years ago
Closed 10 years ago
PlacesCommandHook.addLiveBookmark uses gBrowser.contentDocument, which doesn't exist in e10s browsers
Categories
(Firefox :: Bookmarks & History, defect)
Tracking
()
RESOLVED
FIXED
Firefox 40
People
(Reporter: mconley, Assigned: mconley)
References
Details
Attachments
(1 file)
Bug 1144149 will add contentDocumentAsCPOW and contentWindowAsCPOW shortcuts to gBrowser.
This code should probably be updated to use gBrowser.contentDocumentAsCPOW when that happens, or alternatively, gBrowser.selectedBrowser.contentDocumentAsCPOW.
|
Assignee | |
Comment 1•10 years ago
|
||
|
||
Updated•10 years ago
|
Assignee: nobody → mconley
|
|
Assignee | |
Comment 2•10 years ago
|
||
|
|
Assignee | |
Updated•10 years ago
|
Attachment #8585645 -
Flags: review?(mak77)
|
||
Comment 3•10 years ago
|
||
Comment on attachment 8585645 [details] [diff] [review]
Use contentDocumentAsCPOW instead of contentDocument in PlacesCommandHook.addLiveBookmark. r=?
Review of attachment 8585645 [details] [diff] [review]:
-----------------------------------------------------------------
most of this stuff could "easily" become async, fwiw, it doesn't matter that we show the dialog immediately.
Attachment #8585645 -
Flags: review?(mak77) → review+
|
|
Assignee | |
Comment 4•10 years ago
|
||
Coolbeans - thanks mak!
https://hg.mozilla.org/integration/fx-team/rev/282711269cd3
Whiteboard: [fixed-in-fx-team]
|
||
Comment 5•10 years ago
|
||
Status: NEW → RESOLVED
Closed: 10 years ago
status-firefox40:
--- → fixed
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 40
You need to log in
before you can comment on or make changes to this bug.
Description
•