Closed Bug 1147032 Opened 10 years ago Closed 10 years ago

[music] Simplify the code for showing the scanning progress

Categories

(Firefox OS Graveyard :: Gaia::Music, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Music
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-master fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
b2g-master --- fixed

People

(Reporter: squib, Assigned: squib)

References

Details

Attachments

(1 file)

[gaia] jimporter:music-db-refactor > mozilla-b2g:master
46 bytes, text/x-github-pull-request
dkuo
: review+
Details | Review
Currently, the code for showing the little scanning process overlay is in db.js, which is a bad spot for it; db.js should just be a wrapper layer for MediaDB. This patch moves it to title_bar.js, which makes things a bit simpler. I also changed things so that we use CSS to hide the scanning overlay when there's a back button in the header. That should be less bug-prone than our previous solution.
Attachment #8582543 - Flags: review?(dkuo)
Comment on attachment 8582543 [details] [review] [gaia] jimporter:music-db-refactor > mozilla-b2g:master Jim, thanks for working on this, sorry for keeping you waiting the review, I have tested the patch roughly and it works fine, and the code looks good to me.
Attachment #8582543 - Flags: review?(dkuo) → review+
Keywords: checkin-needed
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Blocks: 1159028
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: